qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: mdroth@linux.vnet.ibm.com
Subject: [Qemu-devel] [PATCH v2 11/26] qapi-visit: Fix two name arguments passed to visitors
Date: Fri, 28 Aug 2015 18:45:51 +0200	[thread overview]
Message-ID: <1440780366-7177-12-git-send-email-armbru@redhat.com> (raw)
In-Reply-To: <1440780366-7177-1-git-send-email-armbru@redhat.com>

The generated code passes mangled schema names to visit_type_enum()
and union's visit_start_struct().  Fix it to pass the names
unadulterated, like we do everywhere else.

Only qapi-schema-test.json actually has names where this makes a
difference: enum __org.qemu_x-Enum, flat union __org.qemu_x-Union2,
simple union __org.qemu_x-Union1 and its implicit enum
__org.qemu_x-Union1Kind.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
---
 scripts/qapi-visit.py | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/scripts/qapi-visit.py b/scripts/qapi-visit.py
index 9fc040e..73f136f 100644
--- a/scripts/qapi-visit.py
+++ b/scripts/qapi-visit.py
@@ -185,12 +185,12 @@ out:
 def generate_visit_enum(name):
     return mcgen('''
 
-void visit_type_%(name)s(Visitor *m, %(name)s *obj, const char *name, Error **errp)
+void visit_type_%(c_name)s(Visitor *m, %(c_name)s *obj, const char *name, Error **errp)
 {
-    visit_type_enum(m, (int *)obj, %(name)s_lookup, "%(name)s", name, errp);
+    visit_type_enum(m, (int *)obj, %(c_name)s_lookup, "%(name)s", name, errp);
 }
 ''',
-                 name=c_name(name))
+                 c_name=c_name(name), name=name)
 
 def generate_visit_alternate(name, members):
     ret = mcgen('''
@@ -278,17 +278,17 @@ def generate_visit_union(expr):
 
     ret += mcgen('''
 
-void visit_type_%(name)s(Visitor *m, %(name)s **obj, const char *name, Error **errp)
+void visit_type_%(c_name)s(Visitor *m, %(c_name)s **obj, const char *name, Error **errp)
 {
     Error *err = NULL;
 
-    visit_start_struct(m, (void **)obj, "%(name)s", name, sizeof(%(name)s), &err);
+    visit_start_struct(m, (void **)obj, "%(name)s", name, sizeof(%(c_name)s), &err);
     if (err) {
         goto out;
     }
     if (*obj) {
 ''',
-                 name=c_name(name))
+                 c_name=c_name(name), name=name)
 
     if base:
         ret += mcgen('''
-- 
2.4.3

  parent reply	other threads:[~2015-08-28 16:46 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-28 16:45 [Qemu-devel] [PATCH v2 00/26] qapi: Another round of fixes and cleanups Markus Armbruster
2015-08-28 16:45 ` [Qemu-devel] [PATCH v2 01/26] qapi: Clarify docs on including the same file multiple times Markus Armbruster
2015-08-28 16:45 ` [Qemu-devel] [PATCH v2 02/26] qapi: Clean up cgen() and mcgen() Markus Armbruster
2015-08-28 16:45 ` [Qemu-devel] [PATCH v2 03/26] qapi: Simplify guardname() Markus Armbruster
2015-08-28 16:45 ` [Qemu-devel] [PATCH v2 04/26] qapi-event: Clean up how name of enum QAPIEvent is made Markus Armbruster
2015-08-28 16:45 ` [Qemu-devel] [PATCH v2 05/26] qapi: Reject -p arguments that break qapi-event.py Markus Armbruster
2015-08-28 16:45 ` [Qemu-devel] [PATCH v2 06/26] qapi: Drop unused and useless parameters and variables Markus Armbruster
2015-08-28 16:45 ` [Qemu-devel] [PATCH v2 07/26] qapi: Fix generated code when flat union has member 'kind' Markus Armbruster
2015-08-28 16:45 ` [Qemu-devel] [PATCH v2 08/26] qapi: Generate a nicer struct for flat unions Markus Armbruster
2015-08-28 16:45 ` [Qemu-devel] [PATCH v2 09/26] qapi-visit: Fix generated code when schema has forward refs Markus Armbruster
2015-08-28 16:45 ` [Qemu-devel] [PATCH v2 10/26] qapi-visit: Replace list implicit_structs by set Markus Armbruster
2015-08-28 16:45 ` Markus Armbruster [this message]
2015-08-28 16:45 ` [Qemu-devel] [PATCH v2 12/26] tests/qapi-schema: Document alternate's enum lacks visit function Markus Armbruster
2015-08-28 16:45 ` [Qemu-devel] [PATCH v2 13/26] tests/qapi-schema: Document events with base don't work Markus Armbruster
2015-08-28 16:45 ` [Qemu-devel] [PATCH v2 14/26] qapi: Document that input visitor semantics are prone to leaks Markus Armbruster
2015-08-28 16:45 ` [Qemu-devel] [PATCH v2 15/26] qapi: Document shortcoming with union 'data' branch Markus Armbruster
2015-08-28 16:45 ` [Qemu-devel] [PATCH v2 16/26] qapi: Document flaws in checking of names Markus Armbruster
2015-08-28 16:45 ` [Qemu-devel] [PATCH v2 17/26] tests/qapi-schema: Restore test case for flat union base bug Markus Armbruster
2015-08-28 16:45 ` [Qemu-devel] [PATCH v2 18/26] tests/qapi-schema: Rename tests from data- to args- Markus Armbruster
2015-08-28 16:45 ` [Qemu-devel] [PATCH v2 19/26] qapi-tests: New tests for union, alternate command arguments Markus Armbruster
2015-08-28 16:46 ` [Qemu-devel] [PATCH v2 20/26] qapi: Fix to reject union command and event arguments Markus Armbruster
2015-08-28 16:46 ` [Qemu-devel] [PATCH v2 21/26] qapi: Command returning anonymous type doesn't work, outlaw Markus Armbruster
2015-08-28 16:46 ` [Qemu-devel] [PATCH v2 22/26] qapi-commands: Fix gen_err_check(e) for e and e != 'local_err' Markus Armbruster
2015-08-28 16:46 ` [Qemu-devel] [PATCH v2 23/26] qapi-commands: Inline gen_marshal_output_call() Markus Armbruster
2015-08-28 16:46 ` [Qemu-devel] [PATCH v2 24/26] qapi-commands: Don't feed output of mcgen() to mcgen() again Markus Armbruster
2015-08-28 16:46 ` [Qemu-devel] [PATCH v2 25/26] qapi-commands: Drop useless initialization Markus Armbruster
2015-08-28 16:46 ` [Qemu-devel] [PATCH v2 26/26] qapi: Generated code cleanup Markus Armbruster
2015-08-31 15:55 ` [Qemu-devel] [PATCH 27/31] qapi: Drop one of two "simple union must not have base" checks Markus Armbruster
2015-08-31 16:05   ` Eric Blake
2015-08-31 15:55 ` [Qemu-devel] [PATCH 28/31] tests/qapi-schema: Cover two more syntax errors Markus Armbruster
2015-08-31 16:09   ` Eric Blake
2015-08-31 15:55 ` [Qemu-devel] [PATCH 29/31] tests/qapi-schema: Cover non-string, non-dictionary members Markus Armbruster
2015-08-31 16:13   ` Eric Blake
2015-08-31 15:55 ` [Qemu-devel] [PATCH 30/31] qapi: Fix errors for " Markus Armbruster
2015-08-31 16:19   ` Eric Blake
2015-08-31 15:55 ` [Qemu-devel] [PATCH 31/31] qapi: Simplify error reporting for array types Markus Armbruster
2015-08-31 16:28   ` Eric Blake
2015-08-31 16:28 ` [Qemu-devel] [PATCH v2 00/26] qapi: Another round of fixes and cleanups Markus Armbruster
2015-09-03  9:59   ` Markus Armbruster
2015-09-03  9:55 ` [Qemu-devel] [PATCH 32/33] docs/qapi-code-gen.txt: Fix QAPI schema examples Markus Armbruster
2015-09-03 14:32   ` Eric Blake
2015-09-03  9:55 ` [Qemu-devel] [PATCH 33/33] qapi: Generators crash when --output-dir isn't given, fix Markus Armbruster
2015-09-03 14:32   ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1440780366-7177-12-git-send-email-armbru@redhat.com \
    --to=armbru@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).