From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54166) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZVMn6-00088i-Op for qemu-devel@nongnu.org; Fri, 28 Aug 2015 12:46:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZVMn5-0000Ht-6s for qemu-devel@nongnu.org; Fri, 28 Aug 2015 12:46:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59466) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZVMn5-0000Hk-1u for qemu-devel@nongnu.org; Fri, 28 Aug 2015 12:46:11 -0400 From: Markus Armbruster Date: Fri, 28 Aug 2015 18:45:45 +0200 Message-Id: <1440780366-7177-6-git-send-email-armbru@redhat.com> In-Reply-To: <1440780366-7177-1-git-send-email-armbru@redhat.com> References: <1440780366-7177-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH v2 05/26] qapi: Reject -p arguments that break qapi-event.py List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: mdroth@linux.vnet.ibm.com qapi-event.py breaks when you ask for a funny prefix like '@'. Protect it. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- scripts/qapi.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/scripts/qapi.py b/scripts/qapi.py index ba11c54..bc3f4d3 100644 --- a/scripts/qapi.py +++ b/scripts/qapi.py @@ -1003,6 +1003,12 @@ def parse_command_line(extra_options = "", extra_long_options = []): for oa in opts: o, a = oa if o in ("-p", "--prefix"): + match = re.match('([A-Za-z_.-][A-Za-z0-9_.-]*)?', a) + if match.end() != len(a): + print >>sys.stderr, \ + "%s: 'funny character '%s' in argument of --prefix" \ + % (sys.argv[0], a[match.end()]) + sys.exit(1) prefix = a elif o in ("-o", "--output-dir"): output_dir = a + "/" -- 2.4.3