* [Qemu-devel] [PATCH] linux-user: Fix warnings caused by missing 'static' attribute @ 2015-08-29 7:29 Stefan Weil 2015-08-29 10:07 ` Peter Maydell 2015-09-06 11:02 ` Michael Tokarev 0 siblings, 2 replies; 3+ messages in thread From: Stefan Weil @ 2015-08-29 7:29 UTC (permalink / raw) To: Riku Voipio; +Cc: QEMU Trivial, Stefan Weil, QEMU Developer Warnings from the Sparse static analysis tool: linux-user/main.c:40:12: warning: symbol 'filename' was not declared. Should it be static? linux-user/main.c:41:12: warning: symbol 'argv0' was not declared. Should it be static? linux-user/main.c:42:5: warning: symbol 'gdbstub_port' was not declared. Should it be static? linux-user/main.c:43:11: warning: symbol 'envlist' was not declared. Should it be static? Signed-off-by: Stefan Weil <sw@weilnetz.de> --- linux-user/main.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/linux-user/main.c b/linux-user/main.c index 2c9658e..b5eafef 100644 --- a/linux-user/main.c +++ b/linux-user/main.c @@ -37,10 +37,10 @@ char *exec_path; int singlestep; -const char *filename; -const char *argv0; -int gdbstub_port; -envlist_t *envlist; +static const char *filename; +static const char *argv0; +static int gdbstub_port; +static envlist_t *envlist; static const char *cpu_model; unsigned long mmap_min_addr; unsigned long guest_base; -- 2.1.4 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] linux-user: Fix warnings caused by missing 'static' attribute 2015-08-29 7:29 [Qemu-devel] [PATCH] linux-user: Fix warnings caused by missing 'static' attribute Stefan Weil @ 2015-08-29 10:07 ` Peter Maydell 2015-09-06 11:02 ` Michael Tokarev 1 sibling, 0 replies; 3+ messages in thread From: Peter Maydell @ 2015-08-29 10:07 UTC (permalink / raw) To: Stefan Weil; +Cc: QEMU Trivial, Riku Voipio, QEMU Developer On 29 August 2015 at 08:29, Stefan Weil <sw@weilnetz.de> wrote: > Warnings from the Sparse static analysis tool: > > linux-user/main.c:40:12: warning: > symbol 'filename' was not declared. Should it be static? > linux-user/main.c:41:12: warning: > symbol 'argv0' was not declared. Should it be static? > linux-user/main.c:42:5: warning: > symbol 'gdbstub_port' was not declared. Should it be static? > linux-user/main.c:43:11: warning: > symbol 'envlist' was not declared. Should it be static? > > Signed-off-by: Stefan Weil <sw@weilnetz.de> > --- Reviewed-by: Peter Maydell <peter.maydell@linaro.org> thanks -- PMM ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] linux-user: Fix warnings caused by missing 'static' attribute 2015-08-29 7:29 [Qemu-devel] [PATCH] linux-user: Fix warnings caused by missing 'static' attribute Stefan Weil 2015-08-29 10:07 ` Peter Maydell @ 2015-09-06 11:02 ` Michael Tokarev 1 sibling, 0 replies; 3+ messages in thread From: Michael Tokarev @ 2015-09-06 11:02 UTC (permalink / raw) To: Stefan Weil, Riku Voipio; +Cc: QEMU Trivial, QEMU Developer 29.08.2015 10:29, Stefan Weil wrote: > Warnings from the Sparse static analysis tool: > > linux-user/main.c:40:12: warning: > symbol 'filename' was not declared. Should it be static? > linux-user/main.c:41:12: warning: > symbol 'argv0' was not declared. Should it be static? > linux-user/main.c:42:5: warning: > symbol 'gdbstub_port' was not declared. Should it be static? > linux-user/main.c:43:11: warning: > symbol 'envlist' was not declared. Should it be static? Applied to -trivial, thanks! /mjt ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-09-06 11:02 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-08-29 7:29 [Qemu-devel] [PATCH] linux-user: Fix warnings caused by missing 'static' attribute Stefan Weil 2015-08-29 10:07 ` Peter Maydell 2015-09-06 11:02 ` Michael Tokarev
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).