From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50938) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZWpd9-0007Li-JZ for qemu-devel@nongnu.org; Tue, 01 Sep 2015 13:46:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZWpd4-0004JF-9A for qemu-devel@nongnu.org; Tue, 01 Sep 2015 13:45:59 -0400 Received: from e39.co.us.ibm.com ([32.97.110.160]:52128) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZWpd4-0004J6-3Q for qemu-devel@nongnu.org; Tue, 01 Sep 2015 13:45:54 -0400 Received: from /spool/local by e39.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 1 Sep 2015 11:45:53 -0600 Received: from b01cxnp22036.gho.pok.ibm.com (b01cxnp22036.gho.pok.ibm.com [9.57.198.26]) by d01dlp01.pok.ibm.com (Postfix) with ESMTP id E53FE38C8062 for ; Tue, 1 Sep 2015 13:45:48 -0400 (EDT) Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by b01cxnp22036.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t81Hjm5j34537682 for ; Tue, 1 Sep 2015 17:45:48 GMT Received: from d01av02.pok.ibm.com (localhost [127.0.0.1]) by d01av02.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t81HjluM013282 for ; Tue, 1 Sep 2015 13:45:48 -0400 From: Michael Roth Date: Tue, 1 Sep 2015 12:00:46 -0500 Message-Id: <1441126866-17199-7-git-send-email-mdroth@linux.vnet.ibm.com> In-Reply-To: <1441126866-17199-1-git-send-email-mdroth@linux.vnet.ibm.com> References: <1441126866-17199-1-git-send-email-mdroth@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [Qemu-devel] [PATCH 06/26] qemu-ga: Prevent QEMU-GA VSS provider from being unregistered on MSI reinstall List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, Leonid Bloch , Michael Roth From: Leonid Bloch Previously, running the .msi would unregister the QEMU GA VSS service if QEMU GA was already installed on the machine, and then register it only if QEMU GA was NOT previously installed. This behavior caused the service to be registered only after the INITIAL installation, and any subsequent run of the .msi (to redo, repair, or upgrade the installation) ended in the service being unregistered. Now, the VSS service is still unregistered if QEMU GA is already installed (so that a fix or an update could be performed) but then it is registered again (if the GA is not being uninstalled) thus finishing the repair/upgrade correctly. Additionally, downgrading is now prevented. If a user would like to downgrade a version, he/she must uninstall the newer version first. Signed-off-by: Leonid Bloch Reviewed-by: Marc-André Lureau Signed-off-by: Michael Roth --- qga/installer/qemu-ga.wxs | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/qga/installer/qemu-ga.wxs b/qga/installer/qemu-ga.wxs index b32064e..c195b4b 100644 --- a/qga/installer/qemu-ga.wxs +++ b/qga/installer/qemu-ga.wxs @@ -58,13 +58,9 @@ /> - - - - + @@ -125,6 +121,7 @@ + - - NOT Installed Installed + NOT REMOVE -- 1.9.1