From: Knut Omang <knut.omang@oracle.com>
To: qemu-devel@nongnu.org
Cc: "Alex Williamson" <alex.williamson@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Knut Omang" <knut.omang@oracle.com>,
"Alexander Graf" <agraf@suse.de>, "Le Tan" <tamlokveer@gmail.com>,
"Andreas Färber" <andreas.faerber@web.de>,
qemu-ppc@nongnu.org, "Jan Kiszka" <jan.kiszka@siemens.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Richard Henderson" <rth@twiddle.net>,
"David Gibson" <david@gibson.dropbear.id.au>
Subject: [Qemu-devel] [PATCH v2 0/2] intel_iommu: Add support for translation for devices behind bridges
Date: Tue, 1 Sep 2015 20:48:20 +0200 [thread overview]
Message-ID: <1441133302-18950-1-git-send-email-knut.omang@oracle.com> (raw)
This patch set changes the data structure used to handle address spaces within
the emulated Intel iommu to support traversal also if bus numbers are dynamically
allocated, as is the case for devices that sit behind root ports or downstream switches.
This means that we cannot use bus number as index, instead a QLIST is used.
This requires a change in the API for setup of IOMMUs which is taken care of by
the first patch. The second patch implements the fix.
The initial patch set had some discussion related to whether this fix, applied to the
bridge code, was applicable to all bridges. No clear conclusion arised as far as I understood,
in the meantime a number of people have run into the same issue as I did which lead me
to implement this, so I gather it might be a useful intermediate solution that works until
a better approach can be found? I believe the IOMMU emulation code has limited usefulness
if it only supports devices sitting directly on the root complex.
This is the thread following the initial patch set:
http://thread.gmane.org/gmane.comp.emulators.qemu/302246
The patch set was also discussed in this thread:
http://thread.gmane.org/gmane.comp.emulators.qemu/316949
Changes from v1:
- Rebased to current master
- Fixed minor syntax issues
Knut Omang (2):
iommu: Replace bus+devfn arguments with PCIDevice* in PCIIOMMUFunc
intel_iommu: Add support for translation for devices behind bridges.
hw/alpha/typhoon.c | 2 +-
hw/i386/intel_iommu.c | 56 +++++++++++++++++++------------------------
hw/pci-host/apb.c | 2 +-
hw/pci-host/prep.c | 3 +--
hw/pci-host/q35.c | 42 +++++++++++++-------------------
hw/pci/pci.c | 7 +++---
hw/pci/pci_bridge.c | 6 +++++
hw/ppc/spapr_pci.c | 2 +-
include/hw/i386/intel_iommu.h | 6 +++--
include/hw/pci/pci.h | 5 +++-
10 files changed, 62 insertions(+), 69 deletions(-)
--
2.4.3
next reply other threads:[~2015-09-01 18:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-01 18:48 Knut Omang [this message]
2015-09-01 18:48 ` [Qemu-devel] [PATCH v2 1/2] iommu: Replace bus+devfn arguments with PCIDevice* in PCIIOMMUFunc Knut Omang
2015-09-01 18:48 ` [Qemu-devel] [PATCH v2 2/2] intel_iommu: Add support for translation for devices behind bridges Knut Omang
2015-09-02 12:30 ` [Qemu-devel] [PATCH v2 0/2] " Marcel Apfelbaum
2015-09-02 13:10 ` Knut Omang
2015-09-02 16:12 ` Alex Williamson
2015-09-02 22:33 ` Benjamin Herrenschmidt
2015-09-03 5:26 ` Knut Omang
2015-09-12 18:37 ` Knut Omang
2015-09-12 23:12 ` Benjamin Herrenschmidt
2015-09-13 7:04 ` Knut Omang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441133302-18950-1-git-send-email-knut.omang@oracle.com \
--to=knut.omang@oracle.com \
--cc=agraf@suse.de \
--cc=alex.williamson@redhat.com \
--cc=andreas.faerber@web.de \
--cc=david@gibson.dropbear.id.au \
--cc=ehabkost@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rth@twiddle.net \
--cc=tamlokveer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).