qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org,
	stefanha@redhat.com, pbonzini@redhat.com,
	John Snow <jsnow@redhat.com>
Subject: [Qemu-devel] [PATCH 1/4] ahci: remove dead reset code
Date: Tue,  1 Sep 2015 16:50:38 -0400	[thread overview]
Message-ID: <1441140641-17631-2-git-send-email-jsnow@redhat.com> (raw)
In-Reply-To: <1441140641-17631-1-git-send-email-jsnow@redhat.com>

This check is dead due to an earlier conditional.
AHCI does not currently support hotplugging, so
checks to see if devices are present or not are useless.

Remove it.

Reported-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: John Snow <jsnow@redhat.com>
---
 hw/ide/ahci.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
index 48749c1..d04a161 100644
--- a/hw/ide/ahci.c
+++ b/hw/ide/ahci.c
@@ -604,10 +604,7 @@ static void ahci_reset_port(AHCIState *s, int port)
     }
 
     s->dev[port].port_state = STATE_RUN;
-    if (!ide_state->blk) {
-        pr->sig = 0;
-        ide_state->status = SEEK_STAT | WRERR_STAT;
-    } else if (ide_state->drive_kind == IDE_CD) {
+    if (ide_state->drive_kind == IDE_CD) {
         pr->sig = SATA_SIGNATURE_CDROM;
         ide_state->lcyl = 0x14;
         ide_state->hcyl = 0xeb;
-- 
2.4.3

  reply	other threads:[~2015-09-01 20:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-01 20:50 [Qemu-devel] [PATCH 0/4] ahci: clean up signature generation John Snow
2015-09-01 20:50 ` John Snow [this message]
2015-09-01 20:50 ` [Qemu-devel] [PATCH 2/4] ahci: fix " John Snow
2015-09-17  8:30   ` Stefan Hajnoczi
2015-09-01 20:50 ` [Qemu-devel] [PATCH 3/4] ahci: remove cmd_fis argument from write_fis_d2h John Snow
2015-09-01 20:50 ` [Qemu-devel] [PATCH 4/4] ahci: clean up initial d2h semantics John Snow
2015-09-16 15:37 ` [Qemu-devel] [PATCH 0/4] ahci: clean up signature generation John Snow
2015-09-17  8:40 ` Stefan Hajnoczi
2015-09-17 18:35   ` John Snow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1441140641-17631-2-git-send-email-jsnow@redhat.com \
    --to=jsnow@redhat.com \
    --cc=armbru@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).