From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42141) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZWsW1-00042A-Rl for qemu-devel@nongnu.org; Tue, 01 Sep 2015 16:50:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZWsW1-0004bG-6Z for qemu-devel@nongnu.org; Tue, 01 Sep 2015 16:50:49 -0400 From: John Snow Date: Tue, 1 Sep 2015 16:50:38 -0400 Message-Id: <1441140641-17631-2-git-send-email-jsnow@redhat.com> In-Reply-To: <1441140641-17631-1-git-send-email-jsnow@redhat.com> References: <1441140641-17631-1-git-send-email-jsnow@redhat.com> Subject: [Qemu-devel] [PATCH 1/4] ahci: remove dead reset code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-block@nongnu.org Cc: kwolf@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, pbonzini@redhat.com, John Snow This check is dead due to an earlier conditional. AHCI does not currently support hotplugging, so checks to see if devices are present or not are useless. Remove it. Reported-by: Stefan Hajnoczi Signed-off-by: John Snow --- hw/ide/ahci.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index 48749c1..d04a161 100644 --- a/hw/ide/ahci.c +++ b/hw/ide/ahci.c @@ -604,10 +604,7 @@ static void ahci_reset_port(AHCIState *s, int port) } s->dev[port].port_state = STATE_RUN; - if (!ide_state->blk) { - pr->sig = 0; - ide_state->status = SEEK_STAT | WRERR_STAT; - } else if (ide_state->drive_kind == IDE_CD) { + if (ide_state->drive_kind == IDE_CD) { pr->sig = SATA_SIGNATURE_CDROM; ide_state->lcyl = 0x14; ide_state->hcyl = 0xeb; -- 2.4.3