From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53869) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXAgr-0003NZ-NF for qemu-devel@nongnu.org; Wed, 02 Sep 2015 12:15:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZXAgn-0000QV-S6 for qemu-devel@nongnu.org; Wed, 02 Sep 2015 12:15:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33768) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXAgn-0000QJ-Ne for qemu-devel@nongnu.org; Wed, 02 Sep 2015 12:15:09 -0400 From: Stefan Hajnoczi Date: Wed, 2 Sep 2015 17:14:49 +0100 Message-Id: <1441210493-19591-4-git-send-email-stefanha@redhat.com> In-Reply-To: <1441210493-19591-1-git-send-email-stefanha@redhat.com> References: <1441210493-19591-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PULL 3/7] rtl8139: use ldl/stl wrapper for unaligned 32-bit access List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell , Stefan Hajnoczi The tx offload feature accesses a 16-bit aligned TCP header struct. The 32-bit fields must be accessed using ldl/stl wrappers since some host architectures fault on unaligned access. Suggested-by: Peter Maydell Signed-off-by: Stefan Hajnoczi Reviewed-by: Jason Wang Message-id: 1438604157-29664-4-git-send-email-stefanha@redhat.com --- hw/net/rtl8139.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/hw/net/rtl8139.c b/hw/net/rtl8139.c index 36be22b..366d1b5 100644 --- a/hw/net/rtl8139.c +++ b/hw/net/rtl8139.c @@ -2118,7 +2118,11 @@ static int rtl8139_cplus_transmit_one(RTL8139State *s) DPRINTF("+++ C+ mode has IP packet\n"); - /* not aligned */ + /* Note on memory alignment: eth_payload_data is 16-bit aligned + * since saved_buffer is allocated with g_malloc() and ETH_HLEN is + * even. 32-bit accesses must use ldl/stl wrappers to avoid + * unaligned accesses. + */ eth_payload_data = saved_buffer + ETH_HLEN; eth_payload_len = saved_size - ETH_HLEN; @@ -2215,7 +2219,7 @@ static int rtl8139_cplus_transmit_one(RTL8139State *s) } DPRINTF("+++ C+ mode TSO TCP seqno %08x\n", - be32_to_cpu(p_tcp_hdr->th_seq)); + ldl_be_p(&p_tcp_hdr->th_seq)); /* add 4 TCP pseudoheader fields */ /* copy IP source and destination fields */ @@ -2271,7 +2275,8 @@ static int rtl8139_cplus_transmit_one(RTL8139State *s) 0, (uint8_t *) dot1q_buffer); /* add transferred count to TCP sequence number */ - p_tcp_hdr->th_seq = cpu_to_be32(chunk_size + be32_to_cpu(p_tcp_hdr->th_seq)); + stl_be_p(&p_tcp_hdr->th_seq, + chunk_size + ldl_be_p(&p_tcp_hdr->th_seq)); ++send_count; } -- 2.4.3