From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57070) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXCI9-0005Jk-6l for qemu-devel@nongnu.org; Wed, 02 Sep 2015 13:57:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZXCI8-0003cQ-8c for qemu-devel@nongnu.org; Wed, 02 Sep 2015 13:57:49 -0400 Received: from mail-pa0-x230.google.com ([2607:f8b0:400e:c03::230]:33460) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXCI7-0003bw-SH for qemu-devel@nongnu.org; Wed, 02 Sep 2015 13:57:47 -0400 Received: by pacex6 with SMTP id ex6so13560125pac.0 for ; Wed, 02 Sep 2015 10:57:47 -0700 (PDT) Sender: Richard Henderson From: Richard Henderson Date: Wed, 2 Sep 2015 10:57:36 -0700 Message-Id: <1441216660-8717-8-git-send-email-rth@twiddle.net> In-Reply-To: <1441216660-8717-1-git-send-email-rth@twiddle.net> References: <1441216660-8717-1-git-send-email-rth@twiddle.net> Subject: [Qemu-devel] [PATCH v2 07/11] target-arm: Recognize SXTB, SXTH, SXTW, ASR List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org ... as aliases of SBFM, and special-case them. Signed-off-by: Richard Henderson --- target-arm/translate-a64.c | 24 +++++++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/target-arm/translate-a64.c b/target-arm/translate-a64.c index a6e5ccd..74dd0f8 100644 --- a/target-arm/translate-a64.c +++ b/target-arm/translate-a64.c @@ -2999,7 +2999,28 @@ static void disas_bitfield(DisasContext *s, uint32_t insn) tcg_rd = cpu_reg(s, rd); tcg_tmp = read_cpu_reg(s, rn, sf); - /* OPTME: probably worth recognizing common cases of ext{8,16,32}{u,s} */ + /* Recognize the common aliases. */ + if (opc == 0) { /* SBFM */ + if (ri == 0) { + if (si == 7) { /* SXTB */ + tcg_gen_ext8s_i64(tcg_rd, tcg_tmp); + goto done; + } else if (si == 15) { /* SXTH */ + tcg_gen_ext16s_i64(tcg_rd, tcg_tmp); + goto done; + } else if (si == 31) { /* SXTW */ + tcg_gen_ext32s_i64(tcg_rd, tcg_tmp); + goto done; + } + } + if (si == 63 || (si == 31 && ri <= si)) { /* ASR */ + if (si == 31) { + tcg_gen_ext32s_i64(tcg_tmp, tcg_tmp); + } + tcg_gen_sari_i64(tcg_rd, tcg_tmp, ri); + goto done; + } + } if (opc != 1) { /* SBFM or UBFM */ tcg_gen_movi_i64(tcg_rd, 0); @@ -3024,6 +3045,7 @@ static void disas_bitfield(DisasContext *s, uint32_t insn) tcg_gen_sari_i64(tcg_rd, tcg_rd, 64 - (pos + len)); } + done: if (!sf) { /* zero extend final result */ tcg_gen_ext32u_i64(tcg_rd, tcg_rd); } -- 2.4.3