From: Max Reitz <mreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Jeff Cody <jcody@redhat.com>,
qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: [Qemu-devel] [PATCH v2 0/4] iotests: Emit signal-kill messages
Date: Wed, 2 Sep 2015 20:52:24 +0200 [thread overview]
Message-ID: <1441219948-13242-1-git-send-email-mreitz@redhat.com> (raw)
Currently, if a qemu-related command (qemu, qemu-io, qemu-img, qemu-nbd)
is invoked in an iotest, receives a signal and is subsequently killed
(e.g. a segmentation fault), this is not logged in the test output. The
first patch in this series makes the bash tests no longer suppress that
line, and the second patch adds a similar notification for the python
tests.
Patch 3 tries to fix some handling of spaces in command filenames, and
apparently actually succeeds in doing so (all Python tests work, most
bash tests work; if they fail, it's the test's fault). However, it does
not fix handling of spaces in arguments: This is because we probably
don't have to worry about that anyway, and because it would be pretty
difficult to fix.
v2:
- Patch 1: Added, pulled in from v4 of my "blockdev: BlockBackend and
media" series (needed in patch 2)
- Patch 2: Added, required because patch 3 now fixes argument handling
for the Python iotests
- Patch 3:
- Fix handling of spaces in command filenames [Jeff]
- Fix argument handling for Python iotests (accidental fallout from
the above)
git-backport-diff against v1:
Key:
[----] : patches are identical
[####] : number of functional differences between upstream/downstream patch
[down] : patch is downstream-only
The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively
001/4:[down] 'iotests: More options for VM.add_drive()'
002/4:[down] 'iotests: Respect -nodefaults in tests 41 and 55'
003/4:[0047] [FC] 'iotests: Do not suppress segfaults in bash tests'
004/4:[----] [--] 'iotests: Warn if python subprocess is killed'
Max Reitz (4):
iotests: More options for VM.add_drive()
iotests: Respect -nodefaults in tests 41 and 55
iotests: Do not suppress segfaults in bash tests
iotests: Warn if python subprocess is killed
tests/qemu-iotests/039 | 19 +++++----------
tests/qemu-iotests/039.out | 6 ++---
tests/qemu-iotests/041 | 12 +++++++---
tests/qemu-iotests/055 | 10 +++++---
tests/qemu-iotests/061 | 6 +++--
tests/qemu-iotests/061.out | 2 ++
tests/qemu-iotests/check | 8 +++----
tests/qemu-iotests/common.config | 29 +++++++++++++++++++----
tests/qemu-iotests/common.rc | 12 +++++++++-
tests/qemu-iotests/iotests.py | 51 ++++++++++++++++++++++++++++++----------
10 files changed, 110 insertions(+), 45 deletions(-)
--
2.5.1
next reply other threads:[~2015-09-02 18:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-02 18:52 Max Reitz [this message]
2015-09-02 18:52 ` [Qemu-devel] [PATCH v2 1/4] iotests: More options for VM.add_drive() Max Reitz
2015-09-02 18:52 ` [Qemu-devel] [PATCH v2 2/4] iotests: Respect -nodefaults in tests 41 and 55 Max Reitz
2015-09-02 19:55 ` Eric Blake
2015-09-02 18:52 ` [Qemu-devel] [PATCH v2 3/4] iotests: Do not suppress segfaults in bash tests Max Reitz
2015-09-02 20:02 ` Eric Blake
2015-09-02 18:52 ` [Qemu-devel] [PATCH v2 4/4] iotests: Warn if python subprocess is killed Max Reitz
2015-09-02 20:17 ` Eric Blake
2015-09-03 15:25 ` [Qemu-devel] [PATCH v2 0/4] iotests: Emit signal-kill messages Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441219948-13242-1-git-send-email-mreitz@redhat.com \
--to=mreitz@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).