From: Richard Henderson <rth@twiddle.net>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org
Subject: [Qemu-devel] [PATCH v15 28/33] target-tilegx: Handle v1cmpeq, v1cmpne
Date: Wed, 2 Sep 2015 18:31:20 -0700 [thread overview]
Message-ID: <1441243885-7495-29-git-send-email-rth@twiddle.net> (raw)
In-Reply-To: <1441243885-7495-1-git-send-email-rth@twiddle.net>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <rth@twiddle.net>
---
target-tilegx/translate.c | 51 +++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 51 insertions(+)
diff --git a/target-tilegx/translate.c b/target-tilegx/translate.c
index 78b87bf..609592a 100644
--- a/target-tilegx/translate.c
+++ b/target-tilegx/translate.c
@@ -93,6 +93,8 @@ typedef struct {
#define OE_IM(E,XY) OE(IMM8_OPCODE_##XY, E##_IMM8_OPCODE_##XY, XY)
#define OE_SH(E,XY) OE(SHIFT_OPCODE_##XY, E##_SHIFT_OPCODE_##XY, XY)
+#define V1_IMM(X) (((X) & 0xff) * 0x0101010101010101ull)
+
static void gen_exception(DisasContext *dc, TileExcp num)
{
@@ -245,6 +247,41 @@ static void gen_mul_half(TCGv tdest, TCGv tsrca, TCGv tsrcb,
tcg_temp_free(t);
}
+/* Equality comparison with zero can be done quickly and efficiently. */
+static void gen_v1cmpeq0(TCGv v)
+{
+ TCGv m = tcg_const_tl(V1_IMM(0x7f));
+ TCGv c = tcg_temp_new();
+
+ /* ~(((v & m) + m) | m | v). Sets the msb for each byte == 0. */
+ tcg_gen_and_tl(c, v, m);
+ tcg_gen_add_tl(c, c, m);
+ tcg_gen_or_tl(c, c, m);
+ tcg_gen_nor_tl(c, c, v);
+ tcg_temp_free(m);
+
+ /* Shift the msb down to form the lsb boolean result. */
+ tcg_gen_shri_tl(v, c, 7);
+ tcg_temp_free(c);
+}
+
+static void gen_v1cmpne0(TCGv v)
+{
+ TCGv m = tcg_const_tl(V1_IMM(0x7f));
+ TCGv c = tcg_temp_new();
+
+ /* (((v & m) + m) | v) & ~m. Sets the msb for each byte != 0. */
+ tcg_gen_and_tl(c, v, m);
+ tcg_gen_add_tl(c, c, m);
+ tcg_gen_or_tl(c, c, v);
+ tcg_gen_andc_tl(c, c, m);
+ tcg_temp_free(m);
+
+ /* Shift the msb down to form the lsb boolean result. */
+ tcg_gen_shri_tl(v, c, 7);
+ tcg_temp_free(c);
+}
+
static TileExcp gen_st_opcode(DisasContext *dc, unsigned dest, unsigned srca,
unsigned srcb, TCGMemOp memop, const char *name)
{
@@ -915,8 +952,13 @@ static TileExcp gen_rrr_opcode(DisasContext *dc, unsigned opext,
case OE_RRR(V1ADD, 0, X1):
case OE_RRR(V1ADIFFU, 0, X0):
case OE_RRR(V1AVGU, 0, X0):
+ return TILEGX_EXCP_OPCODE_UNIMPLEMENTED;
case OE_RRR(V1CMPEQ, 0, X0):
case OE_RRR(V1CMPEQ, 0, X1):
+ tcg_gen_xor_tl(tdest, tsrca, tsrcb);
+ gen_v1cmpeq0(tdest);
+ mnemonic = "v1cmpeq";
+ break;
case OE_RRR(V1CMPLES, 0, X0):
case OE_RRR(V1CMPLES, 0, X1):
case OE_RRR(V1CMPLEU, 0, X0):
@@ -925,8 +967,13 @@ static TileExcp gen_rrr_opcode(DisasContext *dc, unsigned opext,
case OE_RRR(V1CMPLTS, 0, X1):
case OE_RRR(V1CMPLTU, 0, X0):
case OE_RRR(V1CMPLTU, 0, X1):
+ return TILEGX_EXCP_OPCODE_UNIMPLEMENTED;
case OE_RRR(V1CMPNE, 0, X0):
case OE_RRR(V1CMPNE, 0, X1):
+ tcg_gen_xor_tl(tdest, tsrca, tsrcb);
+ gen_v1cmpne0(tdest);
+ mnemonic = "v1cmpne";
+ break;
case OE_RRR(V1DDOTPUA, 0, X0):
case OE_RRR(V1DDOTPUSA, 0, X0):
case OE_RRR(V1DDOTPUS, 0, X0):
@@ -1187,6 +1234,10 @@ static TileExcp gen_rri_opcode(DisasContext *dc, unsigned opext,
case OE_IM(V1ADDI, X1):
case OE_IM(V1CMPEQI, X0):
case OE_IM(V1CMPEQI, X1):
+ tcg_gen_xori_tl(tdest, tsrca, V1_IMM(imm));
+ gen_v1cmpeq0(tdest);
+ mnemonic = "v1cmpeqi";
+ break;
case OE_IM(V1CMPLTSI, X0):
case OE_IM(V1CMPLTSI, X1):
case OE_IM(V1CMPLTUI, X0):
--
2.4.3
next prev parent reply other threads:[~2015-09-03 1:31 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-03 1:30 [Qemu-devel] [PATCH v15 00/33] TileGX basic instructions Richard Henderson
2015-09-03 1:30 ` [Qemu-devel] [PATCH v15 01/33] linux-user: tilegx: Firstly add architecture related features Richard Henderson
2015-09-03 14:53 ` Eric Blake
[not found] ` <55E96A16.5060206@hotmail.com>
2015-09-04 9:52 ` Chen Gang
2015-09-03 1:30 ` [Qemu-devel] [PATCH v15 02/33] linux-user: Support tilegx architecture in linux-user Richard Henderson
2015-09-03 1:30 ` [Qemu-devel] [PATCH v15 03/33] linux-user: Conditionalize syscalls which are not defined in tilegx Richard Henderson
2015-09-03 1:30 ` [Qemu-devel] [PATCH v15 04/33] target-tilegx: Add opcode basic implementation from Tilera Corporation Richard Henderson
2015-09-03 1:30 ` [Qemu-devel] [PATCH v15 05/33] target-tilegx: Modify opcode_tilegx.h to fit QEMU usage Richard Henderson
2015-09-03 1:30 ` [Qemu-devel] [PATCH v15 06/33] target-tilegx: Modify _SPECIAL_ opcodes Richard Henderson
2015-09-03 1:30 ` [Qemu-devel] [PATCH v15 07/33] target-tilegx: Fix LDNA_ADD_IMM8_OPCODE_X1 Richard Henderson
2015-09-03 1:31 ` [Qemu-devel] [PATCH v15 08/33] target-tilegx: Add special register information from Tilera Corporation Richard Henderson
2015-09-03 1:31 ` [Qemu-devel] [PATCH v15 09/33] target-tilegx: Add cpu basic features for linux-user Richard Henderson
2015-09-03 1:31 ` [Qemu-devel] [PATCH v15 10/33] target-tilegx: Add several helpers for instructions translation Richard Henderson
2015-09-03 1:31 ` [Qemu-devel] [PATCH v15 11/33] target-tilegx: Framework for decoding bundles Richard Henderson
2015-09-03 1:31 ` [Qemu-devel] [PATCH v15 12/33] target-tilegx: Generate SEGV properly Richard Henderson
2015-09-03 1:31 ` [Qemu-devel] [PATCH v15 13/33] target-tilegx: Add TILE-Gx building files Richard Henderson
2015-09-03 1:31 ` [Qemu-devel] [PATCH v15 14/33] target-tilegx: Handle simple logical operations Richard Henderson
2015-09-04 16:48 ` Peter Maydell
2015-09-03 1:31 ` [Qemu-devel] [PATCH v15 15/33] target-tilegx: Handle arithmetic instructions Richard Henderson
2015-09-03 1:31 ` [Qemu-devel] [PATCH v15 16/33] target-tilegx: Handle most bit manipulation instructions Richard Henderson
2015-09-04 16:51 ` Peter Maydell
2015-09-03 1:31 ` [Qemu-devel] [PATCH v15 17/33] target-tilegx: Handle basic load and store instructions Richard Henderson
2015-09-03 1:31 ` [Qemu-devel] [PATCH v15 18/33] target-tilegx: Handle post-increment " Richard Henderson
2015-09-03 1:31 ` [Qemu-devel] [PATCH v15 19/33] target-tilegx: Handle unconditional jump instructions Richard Henderson
2015-09-03 1:31 ` [Qemu-devel] [PATCH v15 20/33] target-tilegx: Handle conditional branch instructions Richard Henderson
2015-09-03 1:31 ` [Qemu-devel] [PATCH v15 21/33] target-tilegx: Handle comparison instructions Richard Henderson
2015-09-03 1:31 ` [Qemu-devel] [PATCH v15 22/33] target-tilegx: Implement system and memory management instructions Richard Henderson
2015-09-04 16:54 ` Peter Maydell
2015-09-03 1:31 ` [Qemu-devel] [PATCH v15 23/33] target-tilegx: Handle bitfield instructions Richard Henderson
2015-09-03 1:31 ` [Qemu-devel] [PATCH v15 24/33] target-tilegx: Handle shift instructions Richard Henderson
2015-09-04 16:56 ` Peter Maydell
2015-09-03 1:31 ` [Qemu-devel] [PATCH v15 25/33] target-tilegx: Handle conditional move instructions Richard Henderson
2015-09-03 1:31 ` [Qemu-devel] [PATCH v15 26/33] target-tilegx: Handle scalar multiply instructions Richard Henderson
2015-09-03 1:31 ` [Qemu-devel] [PATCH v15 27/33] target-tilegx: Handle mask instructions Richard Henderson
2015-09-03 1:31 ` Richard Henderson [this message]
2015-09-03 1:31 ` [Qemu-devel] [PATCH v15 29/33] target-tilegx: Handle mtspr, mfspr Richard Henderson
2015-09-04 16:58 ` Peter Maydell
2015-09-03 1:31 ` [Qemu-devel] [PATCH v15 30/33] target-tilegx: Handle atomic instructions Richard Henderson
2015-09-04 17:03 ` Peter Maydell
2015-09-03 1:31 ` [Qemu-devel] [PATCH v15 31/33] target-tilegx: Handle v4int_l/h Richard Henderson
2015-09-03 1:31 ` [Qemu-devel] [PATCH v15 32/33] target-tilegx: Handle v1shli, v1shrui Richard Henderson
2015-09-03 1:31 ` [Qemu-devel] [PATCH v15 33/33] target-tilegx: Handle v1shl, v1shru, v1shrs Richard Henderson
2015-09-03 15:02 ` Eric Blake
2015-09-03 15:38 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441243885-7495-29-git-send-email-rth@twiddle.net \
--to=rth@twiddle.net \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).