From: David Gibson <david@gibson.dropbear.id.au>
To: peter.maydell@linaro.org
Cc: mdroth@linux.vnet.ibm.com, aik@ozlabs.ru, qemu-devel@nongnu.org,
agraf@suse.de, qemu-ppc@nongnu.org,
Bharata B Rao <bharata@linux.vnet.ibm.com>,
David Gibson <david@gibson.dropbear.id.au>
Subject: [Qemu-devel] [PATCH 17/25] spapr: Provide better error message when slots exceed max allowed
Date: Thu, 3 Sep 2015 14:28:08 +1000 [thread overview]
Message-ID: <1441254496-16174-18-git-send-email-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <1441254496-16174-1-git-send-email-david@gibson.dropbear.id.au>
From: Bharata B Rao <bharata@linux.vnet.ibm.com>
Currently when user specifies more slots than allowed max of
SPAPR_MAX_RAM_SLOTS (32), we error out like this:
qemu-system-ppc64: unsupported amount of memory slots: 64
Let the user know about the max allowed slots like this:
qemu-system-ppc64: Specified number of memory slots 64 exceeds max supported 32
Signed-off-by: Bharata B Rao <bharata@linux.vnet.ibm.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
hw/ppc/spapr.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index 95066f4..90caabe 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -1775,8 +1775,8 @@ static void ppc_spapr_init(MachineState *machine)
ram_addr_t hotplug_mem_size = machine->maxram_size - machine->ram_size;
if (machine->ram_slots > SPAPR_MAX_RAM_SLOTS) {
- error_report("unsupported amount of memory slots: %"PRIu64,
- machine->ram_slots);
+ error_report("Specified number of memory slots %"PRIu64" exceeds max supported %d\n",
+ machine->ram_slots, SPAPR_MAX_RAM_SLOTS);
exit(EXIT_FAILURE);
}
--
2.4.3
next prev parent reply other threads:[~2015-09-03 4:28 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-03 4:27 [Qemu-devel] [PATCH 00/25] sPAPR (pseries) patch backlog 2015-00-03 David Gibson
2015-09-03 4:27 ` [Qemu-devel] [PATCH 01/25] spapr: Provide an error message when migration fails due to htab_shift mismatch David Gibson
2015-09-03 4:27 ` [Qemu-devel] [PATCH 02/25] spapr: Create pseries-2.5 machine David Gibson
2015-09-03 4:27 ` [Qemu-devel] [PATCH 03/25] spapr: Initialize hotplug memory address space David Gibson
2015-09-03 4:27 ` [Qemu-devel] [PATCH 04/25] spapr: Add LMB DR connectors David Gibson
2015-09-03 4:27 ` [Qemu-devel] [PATCH 05/25] spapr: Support ibm, dynamic-reconfiguration-memory David Gibson
2015-09-03 4:27 ` [Qemu-devel] [PATCH 06/25] spapr: Make hash table size a factor of maxram_size David Gibson
2015-09-03 4:27 ` [Qemu-devel] [PATCH 07/25] spapr: Memory hotplug support David Gibson
2015-09-03 4:27 ` [Qemu-devel] [PATCH 08/25] spapr: Don't allow memory hotplug to memory less nodes David Gibson
2015-09-03 4:28 ` [Qemu-devel] [PATCH 09/25] spapr: Add /ibm,partition-name David Gibson
2015-09-03 4:28 ` [Qemu-devel] [PATCH 10/25] spapr: Add /rtas/ibm, change-msix-capable David Gibson
2015-09-03 4:28 ` [Qemu-devel] [PATCH 11/25] spapr: Make ibm, change-msi respect 3 return values David Gibson
2015-09-03 4:28 ` [Qemu-devel] [PATCH 12/25] spapr: SPLPAR Characteristics David Gibson
2015-09-03 4:28 ` [Qemu-devel] [PATCH 13/25] spapr_drc: Fix potential undefined behaviour David Gibson
2015-09-03 4:28 ` [Qemu-devel] [PATCH 14/25] spapr: add dumpdtb support David Gibson
2015-09-03 4:28 ` [Qemu-devel] [PATCH 15/25] ppc/spapr: Use qemu_log_mask() for hcall_dprintf() David Gibson
2015-09-03 4:28 ` [Qemu-devel] [PATCH 16/25] spapr: Use QEMU limit for maximum CPUs number David Gibson
2015-09-03 4:28 ` David Gibson [this message]
2015-09-03 4:28 ` [Qemu-devel] [PATCH 18/25] spapr: Populate ibm, associativity-lookup-arrays correctly for non-NUMA David Gibson
2015-09-03 4:28 ` [Qemu-devel] [PATCH 19/25] spapr: Revert to memory@XXXX representation for non-hotplugged memory David Gibson
2015-09-03 4:28 ` [Qemu-devel] [PATCH 20/25] spapr: Support hotplug by specifying DRC count David Gibson
2015-09-03 4:28 ` [Qemu-devel] [PATCH 21/25] spapr: Move memory hotplug to RTAS_LOG_V6_HP_ID_DRC_COUNT type David Gibson
2015-09-03 4:28 ` [Qemu-devel] [PATCH 22/25] spapr_rtas: Prevent QEMU crash during hotplug without a prior device_add David Gibson
2015-09-03 4:28 ` [Qemu-devel] [PATCH 23/25] sPAPR: Introduce rtas_ldq() David Gibson
2015-09-03 4:28 ` [Qemu-devel] [PATCH 24/25] pseries: define coldplugged devices as "configured" David Gibson
2015-09-03 4:28 ` [Qemu-devel] [PATCH 25/25] pseries: Update SLOF firmware image to qemu-slof-20150813 David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441254496-16174-18-git-send-email-david@gibson.dropbear.id.au \
--to=david@gibson.dropbear.id.au \
--cc=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=bharata@linux.vnet.ibm.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).