From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39923) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXVnB-0005Lv-L4 for qemu-devel@nongnu.org; Thu, 03 Sep 2015 10:47:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZXVn8-0004xC-FO for qemu-devel@nongnu.org; Thu, 03 Sep 2015 10:47:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55429) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXVn8-0004x6-3U for qemu-devel@nongnu.org; Thu, 03 Sep 2015 10:47:06 -0400 From: Stefan Hajnoczi Date: Thu, 3 Sep 2015 15:46:58 +0100 Message-Id: <1441291618-20175-2-git-send-email-stefanha@redhat.com> In-Reply-To: <1441291618-20175-1-git-send-email-stefanha@redhat.com> References: <1441291618-20175-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PULL 1/1] trace-events: Add hmp completion List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell , "Dr. David Alan Gilbert" , Stefan Hajnoczi From: "Dr. David Alan Gilbert" Add completion for the trace event names in the hmp trace-event command. Signed-off-by: Dr. David Alan Gilbert Message-id: 1439548063-18410-1-git-send-email-dgilbert@redhat.com Signed-off-by: Stefan Hajnoczi --- hmp-commands.hx | 1 + hmp.h | 1 + monitor.c | 20 ++++++++++++++++++++ 3 files changed, 22 insertions(+) diff --git a/hmp-commands.hx b/hmp-commands.hx index d3b7932..94d2c39 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -271,6 +271,7 @@ ETEXI .params = "name on|off", .help = "changes status of a specific trace event", .mhandler.cmd = hmp_trace_event, + .command_completion = trace_event_completion, }, STEXI diff --git a/hmp.h b/hmp.h index 0cf4f2a..b8f5d33 100644 --- a/hmp.h +++ b/hmp.h @@ -113,6 +113,7 @@ void set_link_completion(ReadLineState *rs, int nb_args, const char *str); void netdev_add_completion(ReadLineState *rs, int nb_args, const char *str); void netdev_del_completion(ReadLineState *rs, int nb_args, const char *str); void ringbuf_write_completion(ReadLineState *rs, int nb_args, const char *str); +void trace_event_completion(ReadLineState *rs, int nb_args, const char *str); void watchdog_action_completion(ReadLineState *rs, int nb_args, const char *str); void migrate_set_capability_completion(ReadLineState *rs, int nb_args, diff --git a/monitor.c b/monitor.c index fc32f12..b432447 100644 --- a/monitor.c +++ b/monitor.c @@ -4429,6 +4429,26 @@ void netdev_del_completion(ReadLineState *rs, int nb_args, const char *str) } } +void trace_event_completion(ReadLineState *rs, int nb_args, const char *str) +{ + size_t len; + + len = strlen(str); + readline_set_completion_index(rs, len); + if (nb_args == 2) { + TraceEventID id; + for (id = 0; id < trace_event_count(); id++) { + const char *event_name = trace_event_get_name(trace_event_id(id)); + if (!strncmp(str, event_name, len)) { + readline_add_completion(rs, event_name); + } + } + } else if (nb_args == 3) { + add_completion_option(rs, str, "on"); + add_completion_option(rs, str, "off"); + } +} + void watchdog_action_completion(ReadLineState *rs, int nb_args, const char *str) { int i; -- 2.4.3