[Qemu-devel] [RFC PATCH] sdhci: Move sdhci.h to include/

[Qemu-devel] [RFC PATCH] sdhci: Move sdhci.h to include/

[Sai Pavan Boddu]

For a easy creation of device directly form sdhci, without building a wrapper around.

Signed-off-by: Sai Pavan Boddu <saipava@xilinx.com>
---
 hw/sd/sdhci.c                 | 2 +-
 {hw/sd => include/hw}/sdhci.h | 0
 2 files changed, 1 insertion(+), 1 deletion(-)
 rename {hw/sd => include/hw}/sdhci.h (100%)

diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c
index e63367b..2469077 100644
--- a/hw/sd/sdhci.c
+++ b/hw/sd/sdhci.c
@@ -29,7 +29,7 @@
 #include "qemu/timer.h"
 #include "qemu/bitops.h"
 
-#include "sdhci.h"
+#include "hw/sdhci.h"
 
 /* host controller debug messages */
 #ifndef SDHC_DEBUG
diff --git a/hw/sd/sdhci.h b/include/hw/sdhci.h
similarity index 100%
rename from hw/sd/sdhci.h
rename to include/hw/sdhci.h
-- 
1.9.1

Re: [Qemu-devel] [RFC PATCH] sdhci: Move sdhci.h to include/

[Alistair Francis]

On Fri, Sep 4, 2015 at 12:12 AM, Sai Pavan Boddu
<sai.pavan.boddu@xilinx.com> wrote:
> For a easy creation of device directly form sdhci, without building a wrapper around.

Can you fix the commit message?

>
> Signed-off-by: Sai Pavan Boddu <saipava@xilinx.com>
> ---
>  hw/sd/sdhci.c                 | 2 +-
>  {hw/sd => include/hw}/sdhci.h | 0

Now that there are two SD related header filesI think we should create
a sd folder under include/hw/ and move the sdhci.h file in there as
well.

Otherwise I think this is a good idea.

Thanks,

Alistair

>  2 files changed, 1 insertion(+), 1 deletion(-)
>  rename {hw/sd => include/hw}/sdhci.h (100%)
>
> diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c
> index e63367b..2469077 100644
> --- a/hw/sd/sdhci.c
> +++ b/hw/sd/sdhci.c
> @@ -29,7 +29,7 @@
>  #include "qemu/timer.h"
>  #include "qemu/bitops.h"
>
> -#include "sdhci.h"
> +#include "hw/sdhci.h"
>
>  /* host controller debug messages */
>  #ifndef SDHC_DEBUG
> diff --git a/hw/sd/sdhci.h b/include/hw/sdhci.h
> similarity index 100%
> rename from hw/sd/sdhci.h
> rename to include/hw/sdhci.h
> --
> 1.9.1
>
>

Re: [Qemu-devel] [RFC PATCH] sdhci: Move sdhci.h to include/

[Sai Pavan Boddu]

> -----Original Message-----
> From: Alistair Francis [mailto:alistair23@gmail.com]
> Sent: Friday, September 04, 2015 11:51 PM
> To: Sai Pavan Boddu
> Cc: qemu-devel@nongnu.org Developers; Sai Pavan Boddu; Peter Maydell;
> Peter Crosthwaite; Alistair Francis; Edgar Iglesias
> Subject: Re: [Qemu-devel] [RFC PATCH] sdhci: Move sdhci.h to include/
>
> On Fri, Sep 4, 2015 at 12:12 AM, Sai Pavan Boddu
> <sai.pavan.boddu@xilinx.com> wrote:
> > For a easy creation of device directly form sdhci, without building a wrapper
> around.
>
> Can you fix the commit message?
>
> >
> > Signed-off-by: Sai Pavan Boddu <saipava@xilinx.com>
> > ---
> >  hw/sd/sdhci.c                 | 2 +-
> >  {hw/sd => include/hw}/sdhci.h | 0
>
> Now that there are two SD related header filesI think we should create
> a sd folder under include/hw/ and move the sdhci.h file in there as
> well.
[Sai Pavan ] well that will be good. Will get that done in next V2.

Thanks,
Sai Pavan
>
> Otherwise I think this is a good idea.
>
> Thanks,
>
> Alistair
>
> >  2 files changed, 1 insertion(+), 1 deletion(-)
> >  rename {hw/sd => include/hw}/sdhci.h (100%)
> >
> > diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c
> > index e63367b..2469077 100644
> > --- a/hw/sd/sdhci.c
> > +++ b/hw/sd/sdhci.c
> > @@ -29,7 +29,7 @@
> >  #include "qemu/timer.h"
> >  #include "qemu/bitops.h"
> >
> > -#include "sdhci.h"
> > +#include "hw/sdhci.h"
> >
> >  /* host controller debug messages */
> >  #ifndef SDHC_DEBUG
> > diff --git a/hw/sd/sdhci.h b/include/hw/sdhci.h
> > similarity index 100%
> > rename from hw/sd/sdhci.h
> > rename to include/hw/sdhci.h
> > --
> > 1.9.1
> >
> >


This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.