From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 03/33] qapi: Simplify guardname()
Date: Fri, 4 Sep 2015 16:21:10 +0200 [thread overview]
Message-ID: <1441376500-14784-4-git-send-email-armbru@redhat.com> (raw)
In-Reply-To: <1441376500-14784-1-git-send-email-armbru@redhat.com>
The guards around built-in declarations lose their _H. It never made
much sense anyway.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
---
scripts/qapi.py | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/scripts/qapi.py b/scripts/qapi.py
index e656beb..ba11c54 100644
--- a/scripts/qapi.py
+++ b/scripts/qapi.py
@@ -958,14 +958,9 @@ def mcgen(code, **kwds):
code = code[1:]
return cgen(code, **kwds)
-def basename(filename):
- return filename.split("/")[-1]
def guardname(filename):
- guard = basename(filename).rsplit(".", 1)[0]
- for substr in [".", " ", "-"]:
- guard = guard.replace(substr, "_")
- return guard.upper() + '_H'
+ return c_name(filename, protect=False).upper()
def guardstart(name):
return mcgen('''
@@ -1035,6 +1030,7 @@ def parse_command_line(extra_options = "", extra_long_options = []):
def open_output(output_dir, do_c, do_h, prefix, c_file, h_file,
c_comment, h_comment):
+ guard = guardname(prefix + h_file)
c_file = output_dir + prefix + c_file
h_file = output_dir + prefix + h_file
@@ -1067,7 +1063,7 @@ def open_output(output_dir, do_c, do_h, prefix, c_file, h_file,
#define %(guard)s
''',
- comment = h_comment, guard = guardname(h_file)))
+ comment = h_comment, guard = guard))
return (fdef, fdecl)
--
2.4.3
next prev parent reply other threads:[~2015-09-04 14:21 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-04 14:21 [Qemu-devel] [PULL 00/33] qapi: Another round of fixes and cleanups Markus Armbruster
2015-09-04 14:21 ` [Qemu-devel] [PULL 01/33] qapi: Clarify docs on including the same file multiple times Markus Armbruster
2015-09-04 14:21 ` [Qemu-devel] [PULL 02/33] qapi: Clean up cgen() and mcgen() Markus Armbruster
2015-09-07 12:42 ` Laurent Desnogues
2015-09-07 14:55 ` Markus Armbruster
2015-09-04 14:21 ` Markus Armbruster [this message]
2015-09-04 14:21 ` [Qemu-devel] [PULL 04/33] qapi-event: Clean up how name of enum QAPIEvent is made Markus Armbruster
2015-09-04 14:21 ` [Qemu-devel] [PULL 05/33] qapi: Reject -p arguments that break qapi-event.py Markus Armbruster
2015-09-04 14:21 ` [Qemu-devel] [PULL 06/33] qapi: Drop unused and useless parameters and variables Markus Armbruster
2015-09-04 14:21 ` [Qemu-devel] [PULL 07/33] qapi: Fix generated code when flat union has member 'kind' Markus Armbruster
2015-09-04 14:21 ` [Qemu-devel] [PULL 08/33] qapi: Generate a nicer struct for flat unions Markus Armbruster
2015-09-04 14:21 ` [Qemu-devel] [PULL 09/33] qapi-visit: Fix generated code when schema has forward refs Markus Armbruster
2015-09-04 14:21 ` [Qemu-devel] [PULL 10/33] qapi-visit: Replace list implicit_structs by set Markus Armbruster
2015-09-04 14:21 ` [Qemu-devel] [PULL 11/33] qapi-visit: Fix two name arguments passed to visitors Markus Armbruster
2015-09-04 14:21 ` [Qemu-devel] [PULL 12/33] tests/qapi-schema: Document alternate's enum lacks visit function Markus Armbruster
2015-09-04 14:21 ` [Qemu-devel] [PULL 13/33] tests/qapi-schema: Document events with base don't work Markus Armbruster
2015-09-04 14:21 ` [Qemu-devel] [PULL 14/33] qapi: Document that input visitor semantics are prone to leaks Markus Armbruster
2015-09-04 14:21 ` [Qemu-devel] [PULL 15/33] qapi: Document shortcoming with union 'data' branch Markus Armbruster
2015-09-04 14:21 ` [Qemu-devel] [PULL 16/33] qapi: Document flaws in checking of names Markus Armbruster
2015-09-04 14:21 ` [Qemu-devel] [PULL 17/33] tests/qapi-schema: Restore test case for flat union base bug Markus Armbruster
2015-09-04 14:21 ` [Qemu-devel] [PULL 18/33] tests/qapi-schema: Rename tests from data- to args- Markus Armbruster
2015-09-04 14:21 ` [Qemu-devel] [PULL 19/33] qapi-tests: New tests for union, alternate command arguments Markus Armbruster
2015-09-04 14:21 ` [Qemu-devel] [PULL 20/33] qapi: Fix to reject union command and event arguments Markus Armbruster
2015-09-04 14:21 ` [Qemu-devel] [PULL 21/33] qapi: Command returning anonymous type doesn't work, outlaw Markus Armbruster
2015-09-04 14:21 ` [Qemu-devel] [PULL 22/33] qapi-commands: Fix gen_err_check(e) for e and e != 'local_err' Markus Armbruster
2015-09-04 14:21 ` [Qemu-devel] [PULL 23/33] qapi-commands: Inline gen_marshal_output_call() Markus Armbruster
2015-09-04 14:21 ` [Qemu-devel] [PULL 24/33] qapi-commands: Don't feed output of mcgen() to mcgen() again Markus Armbruster
2015-09-04 14:21 ` [Qemu-devel] [PULL 25/33] qapi-commands: Drop useless initialization Markus Armbruster
2015-09-04 14:21 ` [Qemu-devel] [PULL 26/33] qapi: Generated code cleanup Markus Armbruster
2015-09-04 14:21 ` [Qemu-devel] [PULL 27/33] qapi: Drop one of two "simple union must not have base" checks Markus Armbruster
2015-09-04 14:21 ` [Qemu-devel] [PULL 28/33] tests/qapi-schema: Cover two more syntax errors Markus Armbruster
2015-09-04 14:21 ` [Qemu-devel] [PULL 29/33] tests/qapi-schema: Cover non-string, non-dictionary members Markus Armbruster
2015-09-04 14:21 ` [Qemu-devel] [PULL 30/33] qapi: Fix errors for " Markus Armbruster
2015-09-04 14:21 ` [Qemu-devel] [PULL 31/33] qapi: Simplify error reporting for array types Markus Armbruster
2015-09-04 14:21 ` [Qemu-devel] [PULL 32/33] docs/qapi-code-gen.txt: Fix QAPI schema examples Markus Armbruster
2015-09-04 14:21 ` [Qemu-devel] [PULL 33/33] qapi: Generators crash when --output-dir isn't given, fix Markus Armbruster
2015-09-04 16:37 ` [Qemu-devel] [PULL 00/33] qapi: Another round of fixes and cleanups Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441376500-14784-4-git-send-email-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).