From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58121) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXtjp-00029o-SP for qemu-devel@nongnu.org; Fri, 04 Sep 2015 12:21:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZXtjk-0002BS-Ou for qemu-devel@nongnu.org; Fri, 04 Sep 2015 12:21:17 -0400 From: Stefan Hajnoczi Date: Fri, 4 Sep 2015 17:21:06 +0100 Message-Id: <1441383666-6590-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PATCH] e1000: Avoid infinite loop in processing transmit descriptor List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , P J P , Jason Wang , qemu-stable@nongnu.org, P J P , Stefan Hajnoczi , Huzaifa Sidhpurwala From: P J P While processing transmit descriptors, it could lead to an infinite loop if 'bytes' was to become zero; Add a check to avoid it. [The guest can force 'bytes' to 0 by setting the hdr_len and mss descriptor fields to 0. --Stefan] Signed-off-by: P J P Signed-off-by: Stefan Hajnoczi --- hw/net/e1000.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/net/e1000.c b/hw/net/e1000.c index 5c6bcd0..09c9e9d 100644 --- a/hw/net/e1000.c +++ b/hw/net/e1000.c @@ -740,7 +740,8 @@ process_tx_desc(E1000State *s, struct e1000_tx_desc *dp) memmove(tp->data, tp->header, tp->hdr_len); tp->size = tp->hdr_len; } - } while (split_size -= bytes); + split_size -= bytes; + } while (bytes && split_size); } else if (!tp->tse && tp->cptse) { // context descriptor TSE is not set, while data descriptor TSE is set DBGOUT(TXERR, "TCP segmentation error\n"); -- 2.4.3