qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com
Subject: [Qemu-devel] [PULL 15/16] qcow2: reorder fields in Qcow2CachedTable to reduce padding
Date: Fri,  4 Sep 2015 22:10:46 +0200	[thread overview]
Message-ID: <1441397447-6516-16-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1441397447-6516-1-git-send-email-kwolf@redhat.com>

From: Alberto Garcia <berto@igalia.com>

Changing the current ordering saves 8 bytes per cache entry in x86_64.

Signed-off-by: Alberto Garcia <berto@igalia.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Message-id: 0bd55291211df3dfb514d0e7d2031dd5c4f9f807.1438690126.git.berto@igalia.com
Signed-off-by: Max Reitz <mreitz@redhat.com>
---
 block/qcow2-cache.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block/qcow2-cache.c b/block/qcow2-cache.c
index 8457458..046f5b8 100644
--- a/block/qcow2-cache.c
+++ b/block/qcow2-cache.c
@@ -37,9 +37,9 @@
 
 typedef struct Qcow2CachedTable {
     int64_t  offset;
-    bool     dirty;
     uint64_t lru_counter;
     int      ref;
+    bool     dirty;
 } Qcow2CachedTable;
 
 struct Qcow2Cache {
-- 
1.8.3.1

  parent reply	other threads:[~2015-09-04 20:11 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-04 20:10 [Qemu-devel] [PULL 00/16] Block patches Kevin Wolf
2015-09-04 20:10 ` [Qemu-devel] [PULL 01/16] qemu-iotests: qemu machine type support Kevin Wolf
2015-09-04 20:10 ` [Qemu-devel] [PULL 02/16] qemu-iotests: disable default qemu devices for cross-platform compatibility Kevin Wolf
2015-09-04 20:10 ` [Qemu-devel] [PULL 03/16] qemu-iotests: s390x: fix test 041 and 055 Kevin Wolf
2015-09-04 20:10 ` [Qemu-devel] [PULL 04/16] qemu-iotests: s390x: fix test 049, reject negative sizes in QemuOpts Kevin Wolf
2015-09-04 20:10 ` [Qemu-devel] [PULL 05/16] qemu-iotests: s390x: fix test 130 Kevin Wolf
2015-09-04 20:10 ` [Qemu-devel] [PULL 06/16] block/raw-posix: Use raw_normalize_devicepath() Kevin Wolf
2015-09-04 20:10 ` [Qemu-devel] [PULL 07/16] qemu-img: Fix crash in amend invocation Kevin Wolf
2015-09-04 20:10 ` [Qemu-devel] [PULL 08/16] iotests: More options for VM.add_drive() Kevin Wolf
2015-09-04 20:10 ` [Qemu-devel] [PULL 09/16] iotests: Respect -nodefaults in tests 41 and 55 Kevin Wolf
2015-09-04 20:10 ` [Qemu-devel] [PULL 10/16] iotests: Do not suppress segfaults in bash tests Kevin Wolf
2015-09-04 20:10 ` [Qemu-devel] [PULL 11/16] iotests: Warn if python subprocess is killed Kevin Wolf
2015-09-04 20:10 ` [Qemu-devel] [PULL 12/16] qcow2: mark the memory as no longer needed after qcow2_cache_empty() Kevin Wolf
2015-09-04 20:10 ` [Qemu-devel] [PULL 13/16] qcow2: add option to clean unused cache entries after some time Kevin Wolf
2015-09-04 20:10 ` [Qemu-devel] [PULL 14/16] docs: document how to configure the qcow2 L2/refcount caches Kevin Wolf
2015-09-04 20:10 ` Kevin Wolf [this message]
2015-09-04 20:10 ` [Qemu-devel] [PULL 16/16] quorum: validate vote threshold against num_children even if read-pattern is fifo Kevin Wolf
2015-09-07 12:18 ` [Qemu-devel] [PULL 00/16] Block patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1441397447-6516-16-git-send-email-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).