From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com
Subject: [Qemu-devel] [PULL 03/16] qemu-iotests: s390x: fix test 041 and 055
Date: Fri, 4 Sep 2015 22:10:34 +0200 [thread overview]
Message-ID: <1441397447-6516-4-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1441397447-6516-1-git-send-email-kwolf@redhat.com>
From: Bo Tu <tubo@linux.vnet.ibm.com>
There is no 'ide-cd' device defined on non-pc platform, so
test_medium_not_found() test should be skipped.
Reviewed-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Michael Mueller <mimu@linux.vnet.ibm.com>
Reviewed-by: Sascha Silbe <silbe@linux.vnet.ibm.com>
Signed-off-by: Xiao Guang Chen <chenxg@linux.vnet.ibm.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
tests/qemu-iotests/041 | 6 ++++++
tests/qemu-iotests/055 | 9 +++++++++
2 files changed, 15 insertions(+)
diff --git a/tests/qemu-iotests/041 b/tests/qemu-iotests/041
index 3d46ed7..de8ea15 100755
--- a/tests/qemu-iotests/041
+++ b/tests/qemu-iotests/041
@@ -167,6 +167,9 @@ class TestSingleDrive(iotests.QMPTestCase):
'target image does not match source after mirroring')
def test_medium_not_found(self):
+ if iotests.qemu_default_machine != 'pc':
+ return
+
result = self.vm.qmp('drive-mirror', device='ide1-cd0', sync='full',
target=target_img)
self.assert_qmp(result, 'error/class', 'GenericError')
@@ -831,6 +834,9 @@ class TestRepairQuorum(iotests.QMPTestCase):
if not self.has_quorum():
return
+ if iotests.qemu_default_machine != 'pc':
+ return
+
result = self.vm.qmp('drive-mirror', device='ide1-cd0', sync='full',
node_name='repair0',
replaces='img1',
diff --git a/tests/qemu-iotests/055 b/tests/qemu-iotests/055
index 017a609..e6e0ac4 100755
--- a/tests/qemu-iotests/055
+++ b/tests/qemu-iotests/055
@@ -104,11 +104,17 @@ class TestSingleDrive(iotests.QMPTestCase):
self.do_test_pause('blockdev-backup', 'drive1', blockdev_target_img)
def test_medium_not_found(self):
+ if iotests.qemu_default_machine != 'pc':
+ return
+
result = self.vm.qmp('drive-backup', device='ide1-cd0',
target=target_img, sync='full')
self.assert_qmp(result, 'error/class', 'GenericError')
def test_medium_not_found_blockdev_backup(self):
+ if iotests.qemu_default_machine != 'pc':
+ return
+
result = self.vm.qmp('blockdev-backup', device='ide1-cd0',
target='drive1', sync='full')
self.assert_qmp(result, 'error/class', 'GenericError')
@@ -323,6 +329,9 @@ class TestSingleTransaction(iotests.QMPTestCase):
self.do_test_pause('blockdev-backup', 'drive1', blockdev_target_img)
def do_test_medium_not_found(self, cmd, target):
+ if iotests.qemu_default_machine != 'pc':
+ return
+
result = self.vm.qmp('transaction', actions=[{
'type': cmd,
'data': { 'device': 'ide1-cd0',
--
1.8.3.1
next prev parent reply other threads:[~2015-09-04 20:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-04 20:10 [Qemu-devel] [PULL 00/16] Block patches Kevin Wolf
2015-09-04 20:10 ` [Qemu-devel] [PULL 01/16] qemu-iotests: qemu machine type support Kevin Wolf
2015-09-04 20:10 ` [Qemu-devel] [PULL 02/16] qemu-iotests: disable default qemu devices for cross-platform compatibility Kevin Wolf
2015-09-04 20:10 ` Kevin Wolf [this message]
2015-09-04 20:10 ` [Qemu-devel] [PULL 04/16] qemu-iotests: s390x: fix test 049, reject negative sizes in QemuOpts Kevin Wolf
2015-09-04 20:10 ` [Qemu-devel] [PULL 05/16] qemu-iotests: s390x: fix test 130 Kevin Wolf
2015-09-04 20:10 ` [Qemu-devel] [PULL 06/16] block/raw-posix: Use raw_normalize_devicepath() Kevin Wolf
2015-09-04 20:10 ` [Qemu-devel] [PULL 07/16] qemu-img: Fix crash in amend invocation Kevin Wolf
2015-09-04 20:10 ` [Qemu-devel] [PULL 08/16] iotests: More options for VM.add_drive() Kevin Wolf
2015-09-04 20:10 ` [Qemu-devel] [PULL 09/16] iotests: Respect -nodefaults in tests 41 and 55 Kevin Wolf
2015-09-04 20:10 ` [Qemu-devel] [PULL 10/16] iotests: Do not suppress segfaults in bash tests Kevin Wolf
2015-09-04 20:10 ` [Qemu-devel] [PULL 11/16] iotests: Warn if python subprocess is killed Kevin Wolf
2015-09-04 20:10 ` [Qemu-devel] [PULL 12/16] qcow2: mark the memory as no longer needed after qcow2_cache_empty() Kevin Wolf
2015-09-04 20:10 ` [Qemu-devel] [PULL 13/16] qcow2: add option to clean unused cache entries after some time Kevin Wolf
2015-09-04 20:10 ` [Qemu-devel] [PULL 14/16] docs: document how to configure the qcow2 L2/refcount caches Kevin Wolf
2015-09-04 20:10 ` [Qemu-devel] [PULL 15/16] qcow2: reorder fields in Qcow2CachedTable to reduce padding Kevin Wolf
2015-09-04 20:10 ` [Qemu-devel] [PULL 16/16] quorum: validate vote threshold against num_children even if read-pattern is fifo Kevin Wolf
2015-09-07 12:18 ` [Qemu-devel] [PULL 00/16] Block patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441397447-6516-4-git-send-email-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).