[Qemu-devel] [PATCH V1] sdhci: use PRIx64 for uint64_t type

[Qemu-devel] [PATCH V1] sdhci: use PRIx64 for uint64_t type

[Sai Pavan Boddu]

Fix compile time warnings, because of type missmatch for unsigned long long type.

Signed-off-by: Sai Pavan Boddu <saipava@xilinx.com>
---
 hw/sd/sdhci.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c
index 2469077..bd1de7d 100644
--- a/hw/sd/sdhci.c
+++ b/hw/sd/sdhci.c
@@ -22,6 +22,7 @@
  * with this program; if not, see <http://www.gnu.org/licenses/>.
  */
 
+#include <inttypes.h>
 #include "hw/hw.h"
 #include "sysemu/block-backend.h"
 #include "sysemu/blockdev.h"
@@ -719,7 +720,7 @@ static void sdhci_do_adma(SDHCIState *s)
             break;
         case SDHC_ADMA_ATTR_ACT_LINK:   /* link to next descriptor table */
             s->admasysaddr = dscr.addr;
-            DPRINT_L1("ADMA link: admasysaddr=0x%lx\n", s->admasysaddr);
+            DPRINT_L1("ADMA link: admasysaddr=0x%" PRIx64 "\n", s->admasysaddr);
             break;
         default:
             s->admasysaddr += dscr.incr;
@@ -727,7 +728,7 @@ static void sdhci_do_adma(SDHCIState *s)
         }
 
         if (dscr.attr & SDHC_ADMA_ATTR_INT) {
-            DPRINT_L1("ADMA interrupt: admasysaddr=0x%lx\n", s->admasysaddr);
+            DPRINT_L1("ADMA interrupt: admasysaddr=0x%" PRIx64 "\n", s->admasysaddr);
             if (s->norintstsen & SDHC_NISEN_DMA) {
                 s->norintsts |= SDHC_NIS_DMA;
             }
-- 
1.9.1

Re: [Qemu-devel] [PATCH V1] sdhci: use PRIx64 for uint64_t type

[Peter Crosthwaite]

On Sat, Sep 5, 2015 at 1:07 AM, Sai Pavan Boddu
<sai.pavan.boddu@xilinx.com> wrote:
> Fix compile time warnings, because of type missmatch for unsigned long long type.
>

Commit message body should wrap to 72 chars. "mismatch".

> Signed-off-by: Sai Pavan Boddu <saipava@xilinx.com>
> ---
>  hw/sd/sdhci.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c
> index 2469077..bd1de7d 100644
> --- a/hw/sd/sdhci.c
> +++ b/hw/sd/sdhci.c
> @@ -22,6 +22,7 @@
>   * with this program; if not, see <http://www.gnu.org/licenses/>.
>   */
>
> +#include <inttypes.h>
>  #include "hw/hw.h"
>  #include "sysemu/block-backend.h"
>  #include "sysemu/blockdev.h"
> @@ -719,7 +720,7 @@ static void sdhci_do_adma(SDHCIState *s)
>              break;
>          case SDHC_ADMA_ATTR_ACT_LINK:   /* link to next descriptor table */
>              s->admasysaddr = dscr.addr;
> -            DPRINT_L1("ADMA link: admasysaddr=0x%lx\n", s->admasysaddr);
> +            DPRINT_L1("ADMA link: admasysaddr=0x%" PRIx64 "\n", s->admasysaddr);

This is just 80 chars. Some posts I saw last few days suggests you
should return if there is only a few (or 0 in this case) chars slack.
As you need to return the one below, I'd do this one too.

>              break;
>          default:
>              s->admasysaddr += dscr.incr;
> @@ -727,7 +728,7 @@ static void sdhci_do_adma(SDHCIState *s)
>          }
>
>          if (dscr.attr & SDHC_ADMA_ATTR_INT) {
> -            DPRINT_L1("ADMA interrupt: admasysaddr=0x%lx\n", s->admasysaddr);
> +            DPRINT_L1("ADMA interrupt: admasysaddr=0x%" PRIx64 "\n", s->admasysaddr);

80+ line.

Regards,
Peter

>              if (s->norintstsen & SDHC_NISEN_DMA) {
>                  s->norintsts |= SDHC_NIS_DMA;
>              }
> --
> 1.9.1
>

Re: [Qemu-devel] [PATCH V1] sdhci: use PRIx64 for uint64_t type

[Sai Pavan Boddu]

> -----Original Message-----
> From: Peter Crosthwaite [mailto:crosthwaitepeter@gmail.com]
> Sent: Saturday, September 05, 2015 1:54 PM
> To: Sai Pavan Boddu
> Cc: qemu-devel@nongnu.org Developers; Peter Maydell; Alistair Francis;
> Edgar Iglesias; Sai Pavan Boddu
> Subject: Re: [PATCH V1] sdhci: use PRIx64 for uint64_t type
> 
> On Sat, Sep 5, 2015 at 1:07 AM, Sai Pavan Boddu
> <sai.pavan.boddu@xilinx.com> wrote:
> > Fix compile time warnings, because of type missmatch for unsigned long
> long type.
> >
> 
> Commit message body should wrap to 72 chars. "mismatch".
> 
> > Signed-off-by: Sai Pavan Boddu <saipava@xilinx.com>
> > ---
> >  hw/sd/sdhci.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c
> > index 2469077..bd1de7d 100644
> > --- a/hw/sd/sdhci.c
> > +++ b/hw/sd/sdhci.c
> > @@ -22,6 +22,7 @@
> >   * with this program; if not, see <http://www.gnu.org/licenses/>.
> >   */
> >
> > +#include <inttypes.h>
> >  #include "hw/hw.h"
> >  #include "sysemu/block-backend.h"
> >  #include "sysemu/blockdev.h"
> > @@ -719,7 +720,7 @@ static void sdhci_do_adma(SDHCIState *s)
> >              break;
> >          case SDHC_ADMA_ATTR_ACT_LINK:   /* link to next descriptor table */
> >              s->admasysaddr = dscr.addr;
> > -            DPRINT_L1("ADMA link: admasysaddr=0x%lx\n", s->admasysaddr);
> > +            DPRINT_L1("ADMA link: admasysaddr=0x%" PRIx64 "\n", s-
> >admasysaddr);
> 
> This is just 80 chars. Some posts I saw last few days suggests you
> should return if there is only a few (or 0 in this case) chars slack.
> As you need to return the one below, I'd do this one too.
> 
> >              break;
> >          default:
> >              s->admasysaddr += dscr.incr;
> > @@ -727,7 +728,7 @@ static void sdhci_do_adma(SDHCIState *s)
> >          }
> >
> >          if (dscr.attr & SDHC_ADMA_ATTR_INT) {
> > -            DPRINT_L1("ADMA interrupt: admasysaddr=0x%lx\n", s-
> >admasysaddr);
> > +            DPRINT_L1("ADMA interrupt: admasysaddr=0x%" PRIx64 "\n", s-
> >admasysaddr);
> 
> 80+ line.
[Sai Pavan ] Thanks, Sending out V2 for the same.

Regards,
Sai 
> 
> Regards,
> Peter
> 
> >              if (s->norintstsen & SDHC_NISEN_DMA) {
> >                  s->norintsts |= SDHC_NIS_DMA;
> >              }
> > --
> > 1.9.1
> >