From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59867) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZYpaU-0006AL-Du for qemu-devel@nongnu.org; Mon, 07 Sep 2015 02:07:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZYpaR-0005dy-5w for qemu-devel@nongnu.org; Mon, 07 Sep 2015 02:07:30 -0400 Received: from e28smtp05.in.ibm.com ([122.248.162.5]:48436) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZYpaQ-0005d8-Ep for qemu-devel@nongnu.org; Mon, 07 Sep 2015 02:07:27 -0400 Received: from /spool/local by e28smtp05.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 7 Sep 2015 11:37:22 +0530 From: Bharata B Rao Date: Mon, 7 Sep 2015 11:37:04 +0530 Message-Id: <1441606024-1238-1-git-send-email-bharata@linux.vnet.ibm.com> Subject: [Qemu-devel] [FIX PATCH] spapr_drc: Return correct state for logical DR in entity_sense() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Bharata B Rao , qemu-ppc@nongnu.org, Michael Roth , david@gibson.dropbear.id.au When drmgr is run in the guest to add a device for which device_add hasn't been issued in QEMU, configure-connector call fails. When configure-connector call fails, the guest would release (*) the previously acquired DRC by setting back the DRC isolation state to ISOLATED and allocation state to UNUSABLE. These calls will be issued only if get-sensor-state call returns PRESENT state. However currently for a logical DR, entity_sense() would unconditinally return UNUSABLE state only. This prevents any subsequent hotplug of the device with that DRC. Fix this by returning the right state in entity_sense() by checking the allocation_state of DRC. (*) https://lists.ozlabs.org/pipermail/linuxppc-dev/2015-September/133430.html Signed-off-by: Bharata B Rao Cc: Michael Roth --- hw/ppc/spapr_drc.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/ppc/spapr_drc.c b/hw/ppc/spapr_drc.c index 9ce844a..2586065 100644 --- a/hw/ppc/spapr_drc.c +++ b/hw/ppc/spapr_drc.c @@ -186,7 +186,11 @@ static sPAPRDREntitySense entity_sense(sPAPRDRConnector *drc) */ state = SPAPR_DR_ENTITY_SENSE_EMPTY; } else { - state = SPAPR_DR_ENTITY_SENSE_UNUSABLE; + if (drc->allocation_state == SPAPR_DR_ALLOCATION_STATE_UNUSABLE) { + state = SPAPR_DR_ENTITY_SENSE_UNUSABLE; + } else { + state = SPAPR_DR_ENTITY_SENSE_PRESENT; + } } } -- 2.1.0