qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com
Subject: [Qemu-devel] [PATCH v3 03/13] qemu-io: Add command 'reopen'
Date: Mon,  7 Sep 2015 15:26:11 +0200	[thread overview]
Message-ID: <1441632381-26638-4-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1441632381-26638-1-git-send-email-kwolf@redhat.com>

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
---
 qemu-io-cmds.c | 90 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 90 insertions(+)

diff --git a/qemu-io-cmds.c b/qemu-io-cmds.c
index 53477e1..d6572a8 100644
--- a/qemu-io-cmds.c
+++ b/qemu-io-cmds.c
@@ -1979,6 +1979,95 @@ static const cmdinfo_t map_cmd = {
        .oneline        = "prints the allocated areas of a file",
 };
 
+static void reopen_help(void)
+{
+    printf(
+"\n"
+" Changes the open options of an already opened image\n"
+"\n"
+" Example:\n"
+" 'reopen -o lazy-refcounts=on' - activates lazy refcount writeback on a qcow2 image\n"
+"\n"
+" -r, -- Reopen the image read-only\n"
+" -c, -- Change the cache mode to the given value\n"
+" -o, -- Changes block driver options (cf. 'open' command)\n"
+"\n");
+}
+
+static int reopen_f(BlockBackend *blk, int argc, char **argv);
+
+static QemuOptsList reopen_opts = {
+    .name = "reopen",
+    .merge_lists = true,
+    .head = QTAILQ_HEAD_INITIALIZER(reopen_opts.head),
+    .desc = {
+        /* no elements => accept any params */
+        { /* end of list */ }
+    },
+};
+
+static const cmdinfo_t reopen_cmd = {
+       .name           = "reopen",
+       .argmin         = 0,
+       .argmax         = -1,
+       .cfunc          = reopen_f,
+       .args           = "[-r] [-c cache] [-o options]",
+       .oneline        = "reopens an image with new options",
+       .help           = reopen_help,
+};
+
+static int reopen_f(BlockBackend *blk, int argc, char **argv)
+{
+    BlockDriverState *bs = blk_bs(blk);
+    QemuOpts *qopts;
+    QDict *opts;
+    int c;
+    int flags = bs->open_flags;
+
+    BlockReopenQueue *brq;
+    Error *local_err = NULL;
+
+    while ((c = getopt(argc, argv, "c:o:r")) != -1) {
+        switch (c) {
+        case 'c':
+            if (bdrv_parse_cache_flags(optarg, &flags) < 0) {
+                error_report("Invalid cache option: %s", optarg);
+                return 0;
+            }
+            break;
+        case 'o':
+            if (!qemu_opts_parse_noisily(&reopen_opts, optarg, 0)) {
+                qemu_opts_reset(&reopen_opts);
+                return 0;
+            }
+            break;
+        case 'r':
+            flags &= ~BDRV_O_RDWR;
+            break;
+        default:
+            qemu_opts_reset(&reopen_opts);
+            return qemuio_command_usage(&reopen_cmd);
+        }
+    }
+
+    if (optind != argc) {
+        qemu_opts_reset(&reopen_opts);
+        return qemuio_command_usage(&reopen_cmd);
+    }
+
+    qopts = qemu_opts_find(&reopen_opts, NULL);
+    opts = qopts ? qemu_opts_to_qdict(qopts, NULL) : NULL;
+    qemu_opts_reset(&reopen_opts);
+
+    brq = bdrv_reopen_queue(NULL, bs, opts, flags);
+    bdrv_reopen_multiple(brq, &local_err);
+    if (local_err) {
+        error_report_err(local_err);
+    }
+
+    return 0;
+}
+
 static int break_f(BlockBackend *blk, int argc, char **argv)
 {
     int ret;
@@ -2266,6 +2355,7 @@ static void __attribute((constructor)) init_qemuio_commands(void)
     qemuio_add_command(&discard_cmd);
     qemuio_add_command(&alloc_cmd);
     qemuio_add_command(&map_cmd);
+    qemuio_add_command(&reopen_cmd);
     qemuio_add_command(&break_cmd);
     qemuio_add_command(&remove_break_cmd);
     qemuio_add_command(&resume_cmd);
-- 
1.8.3.1

  parent reply	other threads:[~2015-09-07 13:26 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-07 13:26 [Qemu-devel] [PATCH v3 00/13] qcow2: reopen: Change driver-specific runtime options Kevin Wolf
2015-09-07 13:26 ` [Qemu-devel] [PATCH v3 01/13] block: Allow specifying driver-specific options to reopen Kevin Wolf
2015-09-07 13:26 ` [Qemu-devel] [PATCH v3 02/13] qemu-io: Remove duplicate 'open' error message Kevin Wolf
2015-09-07 13:26 ` Kevin Wolf [this message]
2015-09-07 13:26 ` [Qemu-devel] [PATCH v3 04/13] qcow2: Improve " Kevin Wolf
2015-09-07 13:26 ` [Qemu-devel] [PATCH v3 05/13] qcow2: Factor out qcow2_update_options() Kevin Wolf
2015-09-07 13:26 ` [Qemu-devel] [PATCH v3 06/13] qcow2: Move qcow2_update_options() call up Kevin Wolf
2015-09-07 13:26 ` [Qemu-devel] [PATCH v3 07/13] qcow2: Move rest of option handling to qcow2_update_options() Kevin Wolf
2015-09-07 19:35   ` Max Reitz
2015-09-07 13:26 ` [Qemu-devel] [PATCH v3 08/13] qcow2: Leave s unchanged on qcow2_update_options() failure Kevin Wolf
2015-09-07 19:38   ` Max Reitz
2015-09-07 13:26 ` [Qemu-devel] [PATCH v3 09/13] qcow2: Fix memory leak in qcow2_update_options() error path Kevin Wolf
2015-09-07 13:26 ` [Qemu-devel] [PATCH v3 10/13] qcow2: Make qcow2_update_options() suitable for transactions Kevin Wolf
2015-09-07 19:41   ` Max Reitz
2015-09-07 13:26 ` [Qemu-devel] [PATCH v3 11/13] qcow2: Support updating driver-specific options in reopen Kevin Wolf
2015-09-07 19:44   ` Max Reitz
2015-09-07 13:26 ` [Qemu-devel] [PATCH v3 12/13] qemu-iotests: Reopen qcow2 with lazy-refcounts change Kevin Wolf
2015-09-07 13:26 ` [Qemu-devel] [PATCH v3 13/13] qemu-iotests: More qcow2 reopen tests Kevin Wolf
2015-09-07 19:45   ` Max Reitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1441632381-26638-4-git-send-email-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).