qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com
Subject: [Qemu-devel] [PATCH v3 04/13] qcow2: Improve error message
Date: Mon,  7 Sep 2015 15:26:12 +0200	[thread overview]
Message-ID: <1441632381-26638-5-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1441632381-26638-1-git-send-email-kwolf@redhat.com>

Eric says that "any" sounds better than "either", and my non-native
feeling says the same, so let's change it.

Suggested-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
---
 block/qcow2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block/qcow2.c b/block/qcow2.c
index a707d8d..b681977 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -1030,7 +1030,7 @@ static int qcow2_open(BlockDriverState *bs, QDict *options, int flags,
         overlap_check_template = QCOW2_OL_ALL;
     } else {
         error_setg(errp, "Unsupported value '%s' for qcow2 option "
-                   "'overlap-check'. Allowed are either of the following: "
+                   "'overlap-check'. Allowed are any of the following: "
                    "none, constant, cached, all", opt_overlap_check);
         ret = -EINVAL;
         goto fail;
-- 
1.8.3.1

  parent reply	other threads:[~2015-09-07 13:26 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-07 13:26 [Qemu-devel] [PATCH v3 00/13] qcow2: reopen: Change driver-specific runtime options Kevin Wolf
2015-09-07 13:26 ` [Qemu-devel] [PATCH v3 01/13] block: Allow specifying driver-specific options to reopen Kevin Wolf
2015-09-07 13:26 ` [Qemu-devel] [PATCH v3 02/13] qemu-io: Remove duplicate 'open' error message Kevin Wolf
2015-09-07 13:26 ` [Qemu-devel] [PATCH v3 03/13] qemu-io: Add command 'reopen' Kevin Wolf
2015-09-07 13:26 ` Kevin Wolf [this message]
2015-09-07 13:26 ` [Qemu-devel] [PATCH v3 05/13] qcow2: Factor out qcow2_update_options() Kevin Wolf
2015-09-07 13:26 ` [Qemu-devel] [PATCH v3 06/13] qcow2: Move qcow2_update_options() call up Kevin Wolf
2015-09-07 13:26 ` [Qemu-devel] [PATCH v3 07/13] qcow2: Move rest of option handling to qcow2_update_options() Kevin Wolf
2015-09-07 19:35   ` Max Reitz
2015-09-07 13:26 ` [Qemu-devel] [PATCH v3 08/13] qcow2: Leave s unchanged on qcow2_update_options() failure Kevin Wolf
2015-09-07 19:38   ` Max Reitz
2015-09-07 13:26 ` [Qemu-devel] [PATCH v3 09/13] qcow2: Fix memory leak in qcow2_update_options() error path Kevin Wolf
2015-09-07 13:26 ` [Qemu-devel] [PATCH v3 10/13] qcow2: Make qcow2_update_options() suitable for transactions Kevin Wolf
2015-09-07 19:41   ` Max Reitz
2015-09-07 13:26 ` [Qemu-devel] [PATCH v3 11/13] qcow2: Support updating driver-specific options in reopen Kevin Wolf
2015-09-07 19:44   ` Max Reitz
2015-09-07 13:26 ` [Qemu-devel] [PATCH v3 12/13] qemu-iotests: Reopen qcow2 with lazy-refcounts change Kevin Wolf
2015-09-07 13:26 ` [Qemu-devel] [PATCH v3 13/13] qemu-iotests: More qcow2 reopen tests Kevin Wolf
2015-09-07 19:45   ` Max Reitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1441632381-26638-5-git-send-email-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).