qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: peter.maydell@linaro.org
Cc: Pierre Morel <pmorel@linux.vnet.ibm.com>,
	qemu-devel@nongnu.org, agraf@suse.de, borntraeger@de.ibm.com,
	jfrei@linux.vnet.ibm.com,
	Cornelia Huck <cornelia.huck@de.ibm.com>
Subject: [Qemu-devel] [PULL 01/23] s390x/css: handle ccw-0 TIC correctly
Date: Mon,  7 Sep 2015 16:48:15 +0200	[thread overview]
Message-ID: <1441637317-14471-2-git-send-email-cornelia.huck@de.ibm.com> (raw)
In-Reply-To: <1441637317-14471-1-git-send-email-cornelia.huck@de.ibm.com>

From: Pierre Morel <pmorel@linux.vnet.ibm.com>

In CCW-0 format TIC command 4 highest bits are ignored in the subchannel.
In CCW-1 format the TIC command 4 highest bits must be 0.
To convert TIC from CCW-0 to CCW-1 we clear the 4 highest bits
to guarantee compatibility.

Signed-off-by: Pierre Morel <pmorel@linux.vnet.ibm.com>
Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
---
 hw/s390x/css.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/hw/s390x/css.c b/hw/s390x/css.c
index 5df450e..2c0782c 100644
--- a/hw/s390x/css.c
+++ b/hw/s390x/css.c
@@ -261,6 +261,9 @@ static CCW1 copy_ccw_from_guest(hwaddr addr, bool fmt1)
         ret.flags = tmp0.flags;
         ret.count = be16_to_cpu(tmp0.count);
         ret.cda = be16_to_cpu(tmp0.cda1) | (tmp0.cda0 << 16);
+        if ((ret.cmd_code & 0x0f) == CCW_CMD_TIC) {
+            ret.cmd_code &= 0x0f;
+        }
     }
     return ret;
 }
-- 
2.5.1

  reply	other threads:[~2015-09-07 14:48 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-07 14:48 [Qemu-devel] [PULL 00/23] s390x: further patches Cornelia Huck
2015-09-07 14:48 ` Cornelia Huck [this message]
2015-09-07 14:48 ` [Qemu-devel] [PULL 02/23] s390x/css: ccw-0 enforces count > 0 Cornelia Huck
2015-09-07 14:48 ` [Qemu-devel] [PULL 03/23] s390x/event-facility: fix receive mask check Cornelia Huck
2015-09-07 14:48 ` [Qemu-devel] [PULL 04/23] s390x/css: start with cleared cstat/dstat Cornelia Huck
2015-09-07 14:48 ` [Qemu-devel] [PULL 05/23] s390x/event-facility: fix location of receive mask Cornelia Huck
2015-09-07 14:48 ` [Qemu-devel] [PULL 06/23] pc-bios/s390-ccw: Device detection in higher subchannel sets Cornelia Huck
2015-09-07 14:48 ` [Qemu-devel] [PULL 07/23] pc-bios/s390-ccw: rebuild image Cornelia Huck
2015-09-07 14:48 ` [Qemu-devel] [PULL 08/23] s390x/kvm: make setting of in-kernel irq routes more efficient Cornelia Huck
2015-09-07 14:48 ` [Qemu-devel] [PULL 09/23] s390x/gdb: support reading/writing of control registers Cornelia Huck
2015-09-07 14:48 ` [Qemu-devel] [PULL 10/23] sclp/s390: rework sclp cpu hotplug device notification Cornelia Huck
2015-09-07 14:48 ` [Qemu-devel] [PULL 11/23] s390/sclp: rework sclp event facility initialization + device realization Cornelia Huck
2015-09-07 14:48 ` [Qemu-devel] [PULL 12/23] s390/sclp: replace sclp event types with proper defines Cornelia Huck
2015-09-07 14:48 ` [Qemu-devel] [PULL 13/23] s390/sclp: temporarily fix unassignment/reassignment of memory subregions Cornelia Huck
2015-09-07 14:48 ` [Qemu-devel] [PULL 14/23] s390/sclp: introduce a root sclp device Cornelia Huck
2015-09-07 14:48 ` [Qemu-devel] [PULL 15/23] s390/sclp: move sclp_execute related functions into the SCLP class Cornelia Huck
2015-09-07 14:48 ` [Qemu-devel] [PULL 16/23] s390/sclp: move sclp_service_interrupt into the sclp device Cornelia Huck
2015-09-07 14:48 ` [Qemu-devel] [PULL 17/23] s390: no need to manually parse for slots and maxmem Cornelia Huck
2015-09-07 14:48 ` [Qemu-devel] [PULL 18/23] s390: disallow memory hotplug for the s390-virtio machine Cornelia Huck
2015-09-07 14:48 ` [Qemu-devel] [PULL 19/23] s390/sclp: ignore memory hotplug operations if it is disabled Cornelia Huck
2015-09-07 14:48 ` [Qemu-devel] [PULL 20/23] s390: move memory calculation into the sclp device Cornelia Huck
2015-09-07 14:48 ` [Qemu-devel] [PULL 21/23] s390: unify allocation of initial memory Cornelia Huck
2015-09-07 14:48 ` [Qemu-devel] [PULL 22/23] s390/sclp: store the increment_size in the sclp device Cornelia Huck
2015-09-07 14:48 ` [Qemu-devel] [PULL 23/23] s390/sclp: simplify calculation of rnmax Cornelia Huck
2015-09-07 16:18 ` [Qemu-devel] [PULL 00/23] s390x: further patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1441637317-14471-2-git-send-email-cornelia.huck@de.ibm.com \
    --to=cornelia.huck@de.ibm.com \
    --cc=agraf@suse.de \
    --cc=borntraeger@de.ibm.com \
    --cc=jfrei@linux.vnet.ibm.com \
    --cc=peter.maydell@linaro.org \
    --cc=pmorel@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).