From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53911)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1ZZH0k-00020g-R9
	for qemu-devel@nongnu.org; Tue, 08 Sep 2015 07:24:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1ZZH0g-0003gv-Nu
	for qemu-devel@nongnu.org; Tue, 08 Sep 2015 07:24:26 -0400
Received: from mx1.redhat.com ([209.132.183.28]:50814)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1ZZH0g-0003gk-JL
	for qemu-devel@nongnu.org; Tue, 08 Sep 2015 07:24:22 -0400
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (Postfix) with ESMTPS id 852758C1A3
	for <qemu-devel@nongnu.org>; Tue,  8 Sep 2015 11:24:21 +0000 (UTC)
Message-ID: <1441711459.27149.44.camel@redhat.com>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Tue, 08 Sep 2015 13:24:19 +0200
In-Reply-To: <55EEB29B.6090108@redhat.com>
References: <1441192690-15413-1-git-send-email-berrange@redhat.com>
	<55EEB29B.6090108@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v6 00/11] Extract TLS handling code from
	VNC server
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org

  Hi,

> I think the patches are great, and I'm not sure if anyone is in a better
> position than you to decide if they're ready.

Lets have a look:

# scripts/get_maintainer.pl -f crypto
"Daniel P. Berrange" <berrange@redhat.com> (maintainer:Cryptography)

> I don't even know if anyone really understands the VNC TLS code and
> thus can review patch 11. :)  So I would just ask you to send a pull
> request.

Agree.  Don't be shy, send a pull request.  Including the vnc bits is
fine with me.  I've briefly looked over the vnc changes, they look sane
to me, and consolidating all the crypto stuff in a nice, reusable way
instead of sprinkling gnutls ifdefs all over the place (including vnc)
certainly is a step into the right direction.

cheers,
  Gerd