From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: stefano.stabellini@eu.citrix.com, xen-devel@lists.xenproject.org,
qemu-devel@nongnu.org
Cc: JBeulich@suse.com
Subject: [Qemu-devel] [PATCH v2] Remove XenPTReg->data and use dev.config for guest configuration values.
Date: Tue, 8 Sep 2015 10:09:52 -0400 [thread overview]
Message-ID: <1441721402-12464-1-git-send-email-konrad.wilk@oracle.com> (raw)
Hey!
Since v1: (http://lists.xen.org/archives/html/xen-devel/2015-07/msg00442.html)
- Acked on review.
RFC [https://lists.gnu.org/archive/html/qemu-devel/2015-06/msg07350.html]
- Added Acks
- Fixed bugs
This patchset is dependent on the "Cleanups + various fixes due to libxl ABI
more logging on errors" which is located at
git://xenbits.xen.org/people/konradwilk/qemu.git v2-cleanups-fixes-due-to-libxlABI
(or http://lists.xen.org/archives/html/xen-devel/2015-09/msg00935.html)
The status of the patches is as follow:
R xen/pt: Use xen_host_pci_get_[byte|word] instead of dev.config
R xen/pt: Sync up the dev.config and data values.
xen/pt: Check if reg->init function sets the 'data' past the reg->size
xen/pt: Remove XenPTReg->data field.
A xen/pt: Log xen_host_pci_get in two init functions
R xen/pt: Log xen_host_pci_get/set errors in MSI code.
R xen/pt: Make xen_pt_unregister_device idempotent
A xen/pt: Move bulk of xen_pt_unregister_device in its own routine.
A xen/pt: Check for return values for xen_host_pci_[get|set] in init
R xen/pt: Don't slurp wholesale the PCI configuration registers
Where 'A' - Acked-by, 'R' - Reviewed-by.
The two patches:
[PATCH v2 03/10] xen/pt: Check if reg->init function sets the 'data' past the reg->size
Stefano asked me to make this a build time check but I could not figure
out how. See http://lists.xen.org/archives/html/xen-devel/2015-08/msg01547.html for details.
[PATCH v2 04/10] xen/pt: Remove XenPTReg->data field.
Stefano asked me to s/word/half-word/g s/dbword/word/ - which this does.
Please review.
The patches are also available at:
>From Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> # This line is ignored.
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: [PATCH v2] Remove XenPTReg->data and use dev.config for guest configuration values.
In-Reply-To:
Hey!
Since v1: (http://lists.xen.org/archives/html/xen-devel/2015-07/msg00442.html)
- Acked on review.
RFC [https://lists.gnu.org/archive/html/qemu-devel/2015-06/msg07350.html]
- Added Acks
- Fixed bugs
This patchset is dependent on the "Cleanups + various fixes due to libxl ABI
more logging on errors" which is located at
git://xenbits.xen.org/people/konradwilk/qemu.git v2-cleanups-fixes-due-to-libxlABI
(or http://lists.xen.org/archives/html/xen-devel/2015-09/msg00935.html)
The status of the patches is as follow:
R xen/pt: Use xen_host_pci_get_[byte|word] instead of dev.config
R xen/pt: Sync up the dev.config and data values.
xen/pt: Check if reg->init function sets the 'data' past the reg->size
xen/pt: Remove XenPTReg->data field.
A xen/pt: Log xen_host_pci_get in two init functions
R xen/pt: Log xen_host_pci_get/set errors in MSI code.
R xen/pt: Make xen_pt_unregister_device idempotent
A xen/pt: Move bulk of xen_pt_unregister_device in its own routine.
A xen/pt: Check for return values for xen_host_pci_[get|set] in init
R xen/pt: Don't slurp wholesale the PCI configuration registers
Where 'A' - Acked-by, 'R' - Reviewed-by.
The two patches:
[PATCH v2 03/10] xen/pt: Check if reg->init function sets the 'data' past the reg->size
Stefano asked me to make this a build time check but I could not figure
out how. See http://lists.xen.org/archives/html/xen-devel/2015-08/msg01547.html for details.
[PATCH v2 04/10] xen/pt: Remove XenPTReg->data field.
Stefano asked me to s/word/half-word/g s/dbword/word/ - which this does.
Please review.
The patches are also available at:
git://xenbits.xen.org/people/konradwilk/qemu.git postxsa120.v2
Thank you!
hw/xen/xen-host-pci-device.c | 5 +
hw/xen/xen-host-pci-device.h | 1 +
hw/xen/xen_pt.c | 152 +++++++++++++++++------------
hw/xen/xen_pt.h | 8 +-
hw/xen/xen_pt_config_init.c | 222 ++++++++++++++++++++++++++++++++-----------
hw/xen/xen_pt_msi.c | 18 +++-
6 files changed, 288 insertions(+), 118 deletions(-)
Konrad Rzeszutek Wilk (10):
xen/pt: Use xen_host_pci_get_[byte|word] instead of dev.config
xen/pt: Sync up the dev.config and data values.
xen/pt: Check if reg->init function sets the 'data' past the reg->size
xen/pt: Remove XenPTReg->data field.
xen/pt: Log xen_host_pci_get in two init functions
xen/pt: Log xen_host_pci_get/set errors in MSI code.
xen/pt: Make xen_pt_unregister_device idempotent
xen/pt: Move bulk of xen_pt_unregister_device in its own routine.
xen/pt: Check for return values for xen_host_pci_[get|set] in init
xen/pt: Don't slurp wholesale the PCI configuration registers
git://xenbits.xen.org/people/konradwilk/qemu.git postxsa120.v2
Thank you!
hw/xen/xen-host-pci-device.c | 5 +
hw/xen/xen-host-pci-device.h | 1 +
hw/xen/xen_pt.c | 152 +++++++++++++++++------------
hw/xen/xen_pt.h | 8 +-
hw/xen/xen_pt_config_init.c | 222 ++++++++++++++++++++++++++++++++-----------
hw/xen/xen_pt_msi.c | 18 +++-
6 files changed, 288 insertions(+), 118 deletions(-)
Konrad Rzeszutek Wilk (10):
xen/pt: Use xen_host_pci_get_[byte|word] instead of dev.config
xen/pt: Sync up the dev.config and data values.
xen/pt: Check if reg->init function sets the 'data' past the reg->size
xen/pt: Remove XenPTReg->data field.
xen/pt: Log xen_host_pci_get in two init functions
xen/pt: Log xen_host_pci_get/set errors in MSI code.
xen/pt: Make xen_pt_unregister_device idempotent
xen/pt: Move bulk of xen_pt_unregister_device in its own routine.
xen/pt: Check for return values for xen_host_pci_[get|set] in init
xen/pt: Don't slurp wholesale the PCI configuration registers
next reply other threads:[~2015-09-08 14:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-08 14:09 Konrad Rzeszutek Wilk [this message]
2015-09-08 14:09 ` [Qemu-devel] [PATCH v2 01/10] xen/pt: Use xen_host_pci_get_[byte|word] instead of dev.config Konrad Rzeszutek Wilk
2015-09-08 14:09 ` [Qemu-devel] [PATCH v2 02/10] xen/pt: Sync up the dev.config and data values Konrad Rzeszutek Wilk
2015-09-08 14:09 ` [Qemu-devel] [PATCH v2 03/10] xen/pt: Check if reg->init function sets the 'data' past the reg->size Konrad Rzeszutek Wilk
2015-09-08 15:23 ` Stefano Stabellini
2015-09-08 14:09 ` [Qemu-devel] [PATCH v2 04/10] xen/pt: Remove XenPTReg->data field Konrad Rzeszutek Wilk
2015-09-08 15:25 ` Stefano Stabellini
2015-09-08 14:09 ` [Qemu-devel] [PATCH v2 05/10] xen/pt: Log xen_host_pci_get in two init functions Konrad Rzeszutek Wilk
2015-09-08 14:09 ` [Qemu-devel] [PATCH v2 06/10] xen/pt: Log xen_host_pci_get/set errors in MSI code Konrad Rzeszutek Wilk
2015-09-08 14:09 ` [Qemu-devel] [PATCH v2 07/10] xen/pt: Make xen_pt_unregister_device idempotent Konrad Rzeszutek Wilk
2015-09-08 14:10 ` [Qemu-devel] [PATCH v2 08/10] xen/pt: Move bulk of xen_pt_unregister_device in its own routine Konrad Rzeszutek Wilk
2015-09-08 14:10 ` [Qemu-devel] [PATCH v2 09/10] xen/pt: Check for return values for xen_host_pci_[get|set] in init Konrad Rzeszutek Wilk
2015-09-08 14:10 ` [Qemu-devel] [PATCH v2 10/10] xen/pt: Don't slurp wholesale the PCI configuration registers Konrad Rzeszutek Wilk
2015-09-08 17:22 ` [Qemu-devel] [PATCH v2] Remove XenPTReg->data and use dev.config for guest configuration values Stefano Stabellini
2015-09-09 15:00 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441721402-12464-1-git-send-email-konrad.wilk@oracle.com \
--to=konrad.wilk@oracle.com \
--cc=JBeulich@suse.com \
--cc=qemu-devel@nongnu.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).