qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: stefano.stabellini@eu.citrix.com, xen-devel@lists.xenproject.org,
	qemu-devel@nongnu.org
Cc: JBeulich@suse.com, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: [Qemu-devel] [PATCH v2 10/10] xen/pt: Don't slurp wholesale the PCI configuration registers
Date: Tue,  8 Sep 2015 10:10:02 -0400	[thread overview]
Message-ID: <1441721402-12464-11-git-send-email-konrad.wilk@oracle.com> (raw)
In-Reply-To: <1441721402-12464-1-git-send-email-konrad.wilk@oracle.com>

Instead we have the emulation registers ->init functions which
consult the host values to see what the initial value should be
and they are responsible for populating the dev.config.

Reviewed-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
 hw/xen/xen_pt.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c
index 80b687f..0f66ea1 100644
--- a/hw/xen/xen_pt.c
+++ b/hw/xen/xen_pt.c
@@ -774,12 +774,7 @@ static int xen_pt_initfn(PCIDevice *d)
     }
 
     /* Initialize virtualized PCI configuration (Extended 256 Bytes) */
-    rc = xen_host_pci_get_block(&s->real_device, 0, d->config,
-                                PCI_CONFIG_SPACE_SIZE);
-    if (rc < 0) {
-        XEN_PT_ERR(d,"Could not read PCI_CONFIG space! (rc:%d)\n", rc);
-        goto err_out;
-    }
+    memset(d->config, 0, PCI_CONFIG_SPACE_SIZE);
 
     s->memory_listener = xen_pt_memory_listener;
     s->io_listener = xen_pt_io_listener;
-- 
2.1.0

  parent reply	other threads:[~2015-09-08 14:10 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-08 14:09 [Qemu-devel] [PATCH v2] Remove XenPTReg->data and use dev.config for guest configuration values Konrad Rzeszutek Wilk
2015-09-08 14:09 ` [Qemu-devel] [PATCH v2 01/10] xen/pt: Use xen_host_pci_get_[byte|word] instead of dev.config Konrad Rzeszutek Wilk
2015-09-08 14:09 ` [Qemu-devel] [PATCH v2 02/10] xen/pt: Sync up the dev.config and data values Konrad Rzeszutek Wilk
2015-09-08 14:09 ` [Qemu-devel] [PATCH v2 03/10] xen/pt: Check if reg->init function sets the 'data' past the reg->size Konrad Rzeszutek Wilk
2015-09-08 15:23   ` Stefano Stabellini
2015-09-08 14:09 ` [Qemu-devel] [PATCH v2 04/10] xen/pt: Remove XenPTReg->data field Konrad Rzeszutek Wilk
2015-09-08 15:25   ` Stefano Stabellini
2015-09-08 14:09 ` [Qemu-devel] [PATCH v2 05/10] xen/pt: Log xen_host_pci_get in two init functions Konrad Rzeszutek Wilk
2015-09-08 14:09 ` [Qemu-devel] [PATCH v2 06/10] xen/pt: Log xen_host_pci_get/set errors in MSI code Konrad Rzeszutek Wilk
2015-09-08 14:09 ` [Qemu-devel] [PATCH v2 07/10] xen/pt: Make xen_pt_unregister_device idempotent Konrad Rzeszutek Wilk
2015-09-08 14:10 ` [Qemu-devel] [PATCH v2 08/10] xen/pt: Move bulk of xen_pt_unregister_device in its own routine Konrad Rzeszutek Wilk
2015-09-08 14:10 ` [Qemu-devel] [PATCH v2 09/10] xen/pt: Check for return values for xen_host_pci_[get|set] in init Konrad Rzeszutek Wilk
2015-09-08 14:10 ` Konrad Rzeszutek Wilk [this message]
2015-09-08 17:22 ` [Qemu-devel] [PATCH v2] Remove XenPTReg->data and use dev.config for guest configuration values Stefano Stabellini
2015-09-09 15:00   ` Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1441721402-12464-11-git-send-email-konrad.wilk@oracle.com \
    --to=konrad.wilk@oracle.com \
    --cc=JBeulich@suse.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).