From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59340) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZbgj-0000ie-CS for qemu-devel@nongnu.org; Wed, 09 Sep 2015 05:29:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZZbgh-0005rQ-NN for qemu-devel@nongnu.org; Wed, 09 Sep 2015 05:29:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60312) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZZbgh-0005rI-Ig for qemu-devel@nongnu.org; Wed, 09 Sep 2015 05:29:07 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 56E6AC0B9893 for ; Wed, 9 Sep 2015 09:29:07 +0000 (UTC) From: Gerd Hoffmann Date: Wed, 9 Sep 2015 11:28:57 +0200 Message-Id: <1441790938-29042-6-git-send-email-kraxel@redhat.com> In-Reply-To: <1441790938-29042-1-git-send-email-kraxel@redhat.com> References: <1441790938-29042-1-git-send-email-kraxel@redhat.com> Subject: [Qemu-devel] [PATCH 5/6] gtk: don't grab input when entering fullscreen. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Gerd Hoffmann Kick off all grabbing logic from fullscreen mode. In the current state it seems to create more problems than it solves though. Try running qemu/gtk fullscreen on one head of a multihead host for example ... There probably was a reason the grab-on-fullscreen logic was added in the first place. So please test and report any issues so we can try to find a sane way to handle it. Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index 2629d97..a17b1d1 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -1140,10 +1140,6 @@ static void gd_menu_full_screen(GtkMenuItem *item, void *opaque) gtk_widget_hide(s->menu_bar); if (vc->type == GD_VC_GFX) { gtk_widget_set_size_request(vc->gfx.drawing_area, -1, -1); - if (qemu_console_is_graphic(vc->gfx.dcl.con)) { - gtk_check_menu_item_set_active - (GTK_CHECK_MENU_ITEM(s->grab_item), TRUE); - } } gtk_window_fullscreen(GTK_WINDOW(s->window)); s->full_screen = TRUE; @@ -1156,8 +1152,6 @@ static void gd_menu_full_screen(GtkMenuItem *item, void *opaque) vc->gfx.scale_x = 1.0; vc->gfx.scale_y = 1.0; gd_update_windowsize(vc); - gtk_check_menu_item_set_active(GTK_CHECK_MENU_ITEM(s->grab_item), - FALSE); } } -- 1.8.3.1