* [Qemu-devel] [PATCH] cocoa: Suppress Cocoa window with -display
@ 2015-09-09 14:08 Rainer Müller
2015-09-09 14:11 ` Andreas Färber
0 siblings, 1 reply; 3+ messages in thread
From: Rainer Müller @ 2015-09-09 14:08 UTC (permalink / raw)
To: qemu-devel
Cc: Peter Maydell, Andreas Färber, Gerd Hoffmann,
Rainer Müller
Do not open a Cocoa window when another display is selected that will be
initialized later. The Cocoa display cannot be selected with -display,
so there is no need to check its argument.
Signed-off-by: Rainer Müller <raimue@codingfarm.de>
---
ui/cocoa.m | 1 +
1 file changed, 1 insertion(+)
diff --git a/ui/cocoa.m b/ui/cocoa.m
index 334e6f6..c24d9f9 100644
--- a/ui/cocoa.m
+++ b/ui/cocoa.m
@@ -1148,6 +1148,7 @@ int main (int argc, const char * argv[]) {
!strcmp(opt, "-nographic") ||
!strcmp(opt, "-version") ||
!strcmp(opt, "-curses") ||
+ !strcmp(opt, "-display") ||
!strcmp(opt, "-qtest")) {
return qemu_main(gArgc, gArgv, *_NSGetEnviron());
}
--
2.5.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] cocoa: Suppress Cocoa window with -display
2015-09-09 14:08 [Qemu-devel] [PATCH] cocoa: Suppress Cocoa window with -display Rainer Müller
@ 2015-09-09 14:11 ` Andreas Färber
2015-09-18 17:43 ` Peter Maydell
0 siblings, 1 reply; 3+ messages in thread
From: Andreas Färber @ 2015-09-09 14:11 UTC (permalink / raw)
To: Rainer Müller, qemu-devel; +Cc: Peter Maydell, Gerd Hoffmann
Am 09.09.2015 um 16:08 schrieb Rainer Müller:
> Do not open a Cocoa window when another display is selected that will be
> initialized later. The Cocoa display cannot be selected with -display,
> so there is no need to check its argument.
>
> Signed-off-by: Rainer Müller <raimue@codingfarm.de>
Makes sense,
Reviewed-by: Andreas Färber <andreas.faerber@web.de>
Thanks,
Andreas
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] cocoa: Suppress Cocoa window with -display
2015-09-09 14:11 ` Andreas Färber
@ 2015-09-18 17:43 ` Peter Maydell
0 siblings, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2015-09-18 17:43 UTC (permalink / raw)
To: Andreas Färber; +Cc: QEMU Developers, Rainer Müller, Gerd Hoffmann
On 9 September 2015 at 15:11, Andreas Färber <andreas.faerber@web.de> wrote:
> Am 09.09.2015 um 16:08 schrieb Rainer Müller:
>> Do not open a Cocoa window when another display is selected that will be
>> initialized later. The Cocoa display cannot be selected with -display,
>> so there is no need to check its argument.
>>
>> Signed-off-by: Rainer Müller <raimue@codingfarm.de>
>
> Makes sense,
>
> Reviewed-by: Andreas Färber <andreas.faerber@web.de>
Applied to master.
thanks
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-09-18 17:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-09 14:08 [Qemu-devel] [PATCH] cocoa: Suppress Cocoa window with -display Rainer Müller
2015-09-09 14:11 ` Andreas Färber
2015-09-18 17:43 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).