From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45827) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Za4oS-0001hD-8l for qemu-devel@nongnu.org; Thu, 10 Sep 2015 12:35:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Za4oP-0008H1-2N for qemu-devel@nongnu.org; Thu, 10 Sep 2015 12:35:04 -0400 Received: from resqmta-po-06v.sys.comcast.net ([2001:558:fe16:19:96:114:154:165]:33972) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Za4oO-0008Gq-Ul for qemu-devel@nongnu.org; Thu, 10 Sep 2015 12:35:01 -0400 From: Eric Blake Date: Thu, 10 Sep 2015 10:34:50 -0600 Message-Id: <1441902890-23064-1-git-send-email-eblake@redhat.com> In-Reply-To: <1441901956-21991-1-git-send-email-eblake@redhat.com> References: <1441901956-21991-1-git-send-email-eblake@redhat.com> Subject: [Qemu-devel] [PATCH 2/1] error: Copy location information in error_copy() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: armbru@redhat.com Commit 1e9b65bb forgot to propagate source information to copied errors. Signed-off-by: Eric Blake --- I noticed this while rebasing my patch (as in 'why did I not get a merge conflict where I expected one?'); of course we could apply this one first, but swapping the patch order implies even more rebasing :) util/error.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/util/error.c b/util/error.c index 9dd474f..b1eb8a2 100644 --- a/util/error.c +++ b/util/error.c @@ -174,6 +174,9 @@ Error *error_copy(const Error *err) err_new = g_malloc0(sizeof(*err)); err_new->msg = g_strdup(err->msg); err_new->err_class = err->err_class; + err_new->src = err->src; + err_new->line = err->line; + err_new->func = err->func; if (err->hint) { err_new->hint = g_string_new(err->hint->str); } -- 2.4.3