From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50151) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZaLc0-0004Uo-4e for qemu-devel@nongnu.org; Fri, 11 Sep 2015 06:31:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZaLbw-0006us-Ur for qemu-devel@nongnu.org; Fri, 11 Sep 2015 06:31:20 -0400 Received: from mail-bl2on0095.outbound.protection.outlook.com ([65.55.169.95]:7360 helo=na01-bl2-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZaLbw-0006ub-Qw for qemu-devel@nongnu.org; Fri, 11 Sep 2015 06:31:16 -0400 From: Sai Pavan Boddu Date: Fri, 11 Sep 2015 16:00:33 +0530 Message-ID: <1441967433-19456-1-git-send-email-saipava@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain Subject: [Qemu-devel] [PATCH V1] sdhci: Fix hostctl2 write logic. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, stefanha@gmail.com, crosthwaitepeter@gmail.com, peter.maydell@linaro.org Cc: alistai@xilinx.com, edgari@xilinx.com, Peter Crosthwaite From: Peter Crosthwaite This should be a shifted MASKED_WRITE like all other instances of non-word aligned registers. Signed-off-by: Peter Crosthwaite --- hw/sd/sdhci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c index 8fd75f7..fd354e3 100644 --- a/hw/sd/sdhci.c +++ b/hw/sd/sdhci.c @@ -1059,7 +1059,7 @@ sdhci_write(void *opaque, hwaddr offset, uint64_t val, unsigned size) value |= SDHC_CTRL2_SAMPLING_CLKSEL; } s->acmd12errsts = value; - s->hostctl2 = value >> 16; + MASKED_WRITE(s->hostctl2, mask >> 16, value >> 16); break; case SDHC_CLKCON: if (!(mask & 0xFF000000)) { -- 2.1.1