qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Gabriel L. Somlo" <somlo@cmu.edu>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, drjones@redhat.com,
	matt.fleming@intel.com, ehabkost@redhat.com, mst@redhat.com,
	zhaoshenglong@huawei.com, leif.lindholm@linaro.org,
	ard.biesheuvel@linaro.org, kevin@koconnor.net, kraxel@redhat.com,
	pbonzini@redhat.com, imammedo@redhat.com, markmb@redhat.com,
	lersek@redhat.com, rth@twiddle.net
Subject: [Qemu-devel] [RFC PATCH 0/3] adding acpi node for fw_cfg on pc and arm
Date: Sat, 12 Sep 2015 19:30:39 -0400	[thread overview]
Message-ID: <1442100642-7258-1-git-send-email-somlo@cmu.edu> (raw)

This series adds a fw_cfg device node to the SSDT (on pc), or to the
DSDT (on arm).

	- Patch 1/3 moves (and renames) the BIOS_CFG_IOPORT (0x510)
	  define from pc.c to pc.h, so that it could be used from
	  acpi-build.c in patch 2/3.

	- Patch 2/3 adds a fw_cfg node to the pc SSDT.

	- Patch 3/3 adds a fw_cfg node to the arm DSDT.

I made up some names - "FWCF" for the node name, and "FWCF0001"
for _HID; no idea whether that's appropriate, or how else I should
figure out what to use instead...

Also, using scope "\\_SB", based on where fw_cfg shows up in the
output of "info qtree". Again, if that's wrong, please point me in
the right direction.

Re. 3/3 (also mentioned after the commit blurb in the patch itself),
I noticed none of the other DSDT entries contain a _STA field, wondering
why it would (not) make sense to include that, same as on the PC.

TIA for any feedback, comments, reviews, etc.
 --Gabriel

Gabriel L. Somlo (3):
  pc: fw_cfg: move ioport base constant to pc.h
  acpi: pc: add fw_cfg device node to ssdt
  acpi: arm: add fw_cfg device node to dsdt

 hw/arm/virt-acpi-build.c | 18 ++++++++++++++++++
 hw/i386/acpi-build.c     | 19 +++++++++++++++++++
 hw/i386/pc.c             |  5 ++---
 include/hw/i386/pc.h     |  3 +++
 4 files changed, 42 insertions(+), 3 deletions(-)

-- 
2.4.3

             reply	other threads:[~2015-09-12 23:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-12 23:30 Gabriel L. Somlo [this message]
2015-09-12 23:30 ` [Qemu-devel] [RFC PATCH 1/3] pc: fw_cfg: move ioport base constant to pc.h Gabriel L. Somlo
2015-09-13 10:51   ` Marc Marí
2015-09-13 17:28     ` Gabriel L. Somlo
2015-09-13 20:16       ` Marc Marí
2015-09-12 23:30 ` [Qemu-devel] [RFC PATCH 2/3] acpi: pc: add fw_cfg device node to ssdt Gabriel L. Somlo
2015-09-13 11:45   ` Michael S. Tsirkin
2015-09-13 17:07     ` Gabriel L. Somlo
2015-09-14 15:48   ` Eduardo Habkost
2015-09-12 23:30 ` [Qemu-devel] [RFC PATCH 3/3] acpi: arm: add fw_cfg device node to dsdt Gabriel L. Somlo
2015-09-14  8:36   ` Shannon Zhao
2015-09-14  8:48   ` Igor Mammedov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1442100642-7258-1-git-send-email-somlo@cmu.edu \
    --to=somlo@cmu.edu \
    --cc=ard.biesheuvel@linaro.org \
    --cc=drjones@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=kevin@koconnor.net \
    --cc=kraxel@redhat.com \
    --cc=leif.lindholm@linaro.org \
    --cc=lersek@redhat.com \
    --cc=markmb@redhat.com \
    --cc=matt.fleming@intel.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=zhaoshenglong@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).