qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Gabriel L. Somlo" <somlo@cmu.edu>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, drjones@redhat.com,
	matt.fleming@intel.com, ehabkost@redhat.com, mst@redhat.com,
	zhaoshenglong@huawei.com, leif.lindholm@linaro.org,
	ard.biesheuvel@linaro.org, kevin@koconnor.net, kraxel@redhat.com,
	pbonzini@redhat.com, imammedo@redhat.com, markmb@redhat.com,
	lersek@redhat.com, rth@twiddle.net
Subject: [Qemu-devel] [RFC PATCH 2/3] acpi: pc: add fw_cfg device node to ssdt
Date: Sat, 12 Sep 2015 19:30:41 -0400	[thread overview]
Message-ID: <1442100642-7258-3-git-send-email-somlo@cmu.edu> (raw)
In-Reply-To: <1442100642-7258-1-git-send-email-somlo@cmu.edu>

Add a fw_cfg device node to the ACPI SSDT. While the guest-side
BIOS can't utilize this information (since it has to access the
hard-coded fw_cfg device to extract ACPI tables to begin with),
having fw_cfg listed in ACPI will help the guest kernel keep a
more accurate inventory of in-use IO port regions.

Signed-off-by: Gabriel Somlo <somlo@cmu.edu>
---
 hw/i386/acpi-build.c | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index 95e0c65..9d0ec22 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -1071,6 +1071,25 @@ build_ssdt(GArray *table_data, GArray *linker,
     aml_append(scope, aml_name_decl("_S5", pkg));
     aml_append(ssdt, scope);
 
+    if (guest_info->fw_cfg) {
+        scope = aml_scope("\\_SB");
+        dev = aml_device("FWCF");
+
+        aml_append(dev, aml_name_decl("_HID", aml_string("FWCF0001")));
+        /* device present, functioning, decoding, not shown in UI */
+        aml_append(dev, aml_name_decl("_STA", aml_int(0xB)));
+
+        crs = aml_resource_template();
+        aml_append(crs,
+            aml_io(AML_DECODE16, FW_CFG_IO_BASE, FW_CFG_IO_BASE,
+                   0x01, FW_CFG_IO_SIZE)
+        );
+        aml_append(dev, aml_name_decl("_CRS", crs));
+
+        aml_append(scope, dev);
+        aml_append(ssdt, scope);
+    }
+
     if (misc->applesmc_io_base) {
         scope = aml_scope("\\_SB.PCI0.ISA");
         dev = aml_device("SMC");
-- 
2.4.3

  parent reply	other threads:[~2015-09-12 23:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-12 23:30 [Qemu-devel] [RFC PATCH 0/3] adding acpi node for fw_cfg on pc and arm Gabriel L. Somlo
2015-09-12 23:30 ` [Qemu-devel] [RFC PATCH 1/3] pc: fw_cfg: move ioport base constant to pc.h Gabriel L. Somlo
2015-09-13 10:51   ` Marc Marí
2015-09-13 17:28     ` Gabriel L. Somlo
2015-09-13 20:16       ` Marc Marí
2015-09-12 23:30 ` Gabriel L. Somlo [this message]
2015-09-13 11:45   ` [Qemu-devel] [RFC PATCH 2/3] acpi: pc: add fw_cfg device node to ssdt Michael S. Tsirkin
2015-09-13 17:07     ` Gabriel L. Somlo
2015-09-14 15:48   ` Eduardo Habkost
2015-09-12 23:30 ` [Qemu-devel] [RFC PATCH 3/3] acpi: arm: add fw_cfg device node to dsdt Gabriel L. Somlo
2015-09-14  8:36   ` Shannon Zhao
2015-09-14  8:48   ` Igor Mammedov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1442100642-7258-3-git-send-email-somlo@cmu.edu \
    --to=somlo@cmu.edu \
    --cc=ard.biesheuvel@linaro.org \
    --cc=drjones@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=kevin@koconnor.net \
    --cc=kraxel@redhat.com \
    --cc=leif.lindholm@linaro.org \
    --cc=lersek@redhat.com \
    --cc=markmb@redhat.com \
    --cc=matt.fleming@intel.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=zhaoshenglong@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).