From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40667) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbSJq-0006mn-5w for qemu-devel@nongnu.org; Mon, 14 Sep 2015 07:53:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZbSJm-0004oR-6m for qemu-devel@nongnu.org; Mon, 14 Sep 2015 07:53:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33821) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbSJm-0004oK-1V for qemu-devel@nongnu.org; Mon, 14 Sep 2015 07:53:06 -0400 From: Markus Armbruster Date: Mon, 14 Sep 2015 13:53:03 +0200 Message-Id: <1442231583-23535-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH] linux-user: Use g_new() & friends where that makes obvious sense List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: riku.voipio@iki.fi g_new(T, n) is neater than g_malloc(sizeof(T) * n). It's also safer, for two reasons. One, it catches multiplication overflowing size_t. Two, it returns T * rather than void *, which lets the compiler catch more type errors. This commit only touches allocations with size arguments of the form sizeof(T). Same Coccinelle semantic patchas in commit b45c03f. Signed-off-by: Markus Armbruster --- linux-user/elfload.c | 2 +- linux-user/main.c | 2 +- linux-user/syscall.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/linux-user/elfload.c b/linux-user/elfload.c index eca0c7f..6584f0b 100644 --- a/linux-user/elfload.c +++ b/linux-user/elfload.c @@ -2848,7 +2848,7 @@ static int fill_note_info(struct elf_note_info *info, TaskState *ts = (TaskState *)cpu->opaque; int i; - info->notes = g_malloc0(NUMNOTES * sizeof (struct memelfnote)); + info->notes = g_new0(struct memelfnote, NUMNOTES); if (info->notes == NULL) return (-ENOMEM); info->prstatus = g_malloc0(sizeof (*info->prstatus)); diff --git a/linux-user/main.c b/linux-user/main.c index 829ee64..1ff821d 100644 --- a/linux-user/main.c +++ b/linux-user/main.c @@ -4014,7 +4014,7 @@ int main(int argc, char **argv, char **envp) } target_argv[target_argc] = NULL; - ts = g_malloc0 (sizeof(TaskState)); + ts = g_new0(TaskState, 1); init_task_state(ts); /* build Task State */ ts->info = info; diff --git a/linux-user/syscall.c b/linux-user/syscall.c index c0fabf7..60c62b8 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -4560,7 +4560,7 @@ static int do_fork(CPUArchState *env, unsigned int flags, abi_ulong newsp, new_thread_info info; pthread_attr_t attr; - ts = g_malloc0(sizeof(TaskState)); + ts = g_new0(TaskState, 1); init_task_state(ts); /* we create a new CPU instance. */ new_env = cpu_copy(env); -- 2.4.3