qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@gmail.com>
Cc: Dave Airlie <airlied@gmail.com>, QEMU <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] virtio-gpu: cursor update not in sync with resource update
Date: Mon, 14 Sep 2015 16:06:39 +0200	[thread overview]
Message-ID: <1442239599.13588.5.camel@redhat.com> (raw)
In-Reply-To: <CAJ+F1CKywA+Y9-aJ4oK=j72VZq6BS7CX_SKqWrfZCK3o9TOWog@mail.gmail.com>

  Hi,

> Afaik, the goal of the seperate cursor queue is to update cursor
> quickly (probably to give good input responsiveness). However, the
> VIRTIO_GPU_CMD_UPDATE_CURSOR references a surface that is uploaded via
> the ctrl queue. The same resource id may be reused for cursor update.
> But there is no synchronization between the two queues. So often, the
> cursor set results in last update being shown. Should the kernel wait
> for the update to finish?

Yes (for new cursors).

> But then why having 2 different queues?
> Should the update be done on the cursor queue instead? or should the
> different cursor be cached (with different id) and qemu to do the
> synchronization?

The guest can upload different cursors and then switch between them
without re-uploading and therefore without ctrl queue updates.  Thats
why they have an id in the first place ...

cheers,
  Gerd

  reply	other threads:[~2015-09-14 14:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-14 12:40 [Qemu-devel] virtio-gpu: cursor update not in sync with resource update Marc-André Lureau
2015-09-14 14:06 ` Gerd Hoffmann [this message]
2015-09-14 15:17   ` Marc-André Lureau
2015-09-14 21:08     ` Dave Airlie
2015-09-14 21:14       ` Marc-André Lureau
2015-09-14 21:18         ` Dave Airlie
2015-09-15  6:20           ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1442239599.13588.5.camel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=airlied@gmail.com \
    --cc=marcandre.lureau@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).