From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Jeff Cody <jcody@redhat.com>,
Max Reitz <mreitz@redhat.com>,
vsementsov@parallels.com, stefanha@redhat.com,
John Snow <jsnow@redhat.com>
Subject: [Qemu-devel] [PATCH v6 10/14] blockdev: make BlockJobTxn available to qmp 'transaction'
Date: Tue, 15 Sep 2015 14:11:49 +0800 [thread overview]
Message-ID: <1442297513-7001-11-git-send-email-famz@redhat.com> (raw)
In-Reply-To: <1442297513-7001-1-git-send-email-famz@redhat.com>
From: Stefan Hajnoczi <stefanha@redhat.com>
Provide a BlockJobTxn to actions executed in a qmp 'transaction'
command. This allows actions to make their block jobs either complete
as a group or fail/cancel together.
The next patch adds the first user.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Fam Zheng <famz@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
Signed-off-by: Fam Zheng <famz@redhat.com>
---
blockdev.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/blockdev.c b/blockdev.c
index 4ebded8..93a9eef 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -1285,6 +1285,7 @@ typedef struct BlkActionOps {
struct BlkActionState {
TransactionAction *action;
const BlkActionOps *ops;
+ BlockJobTxn *block_job_txn;
QSIMPLEQ_ENTRY(BlkActionState) entry;
};
@@ -1889,12 +1890,15 @@ static const BlkActionOps actions[] = {
void qmp_transaction(TransactionActionList *dev_list, Error **errp)
{
TransactionActionList *dev_entry = dev_list;
+ BlockJobTxn *block_job_txn;
BlkActionState *state, *next;
Error *local_err = NULL;
QSIMPLEQ_HEAD(snap_bdrv_states, BlkActionState) snap_bdrv_states;
QSIMPLEQ_INIT(&snap_bdrv_states);
+ block_job_txn = block_job_txn_new();
+
/* drain all i/o before any operations */
bdrv_drain_all();
@@ -1914,6 +1918,7 @@ void qmp_transaction(TransactionActionList *dev_list, Error **errp)
state = g_malloc0(ops->instance_size);
state->ops = ops;
state->action = dev_info;
+ state->block_job_txn = block_job_txn;
QSIMPLEQ_INSERT_TAIL(&snap_bdrv_states, state, entry);
state->ops->prepare(state, &local_err);
@@ -1946,6 +1951,7 @@ exit:
}
g_free(state);
}
+ block_job_txn_unref(block_job_txn);
}
--
2.4.3
next prev parent reply other threads:[~2015-09-15 6:12 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-15 6:11 [Qemu-devel] [PATCH v6 00/14] block: incremental backup transactions using BlockJobTxn Fam Zheng
2015-09-15 6:11 ` [Qemu-devel] [PATCH v6 01/14] qapi: Add transaction support to block-dirty-bitmap operations Fam Zheng
2015-09-15 14:36 ` Eric Blake
2015-09-15 6:11 ` [Qemu-devel] [PATCH v6 02/14] iotests: add transactional incremental backup test Fam Zheng
2015-09-15 6:11 ` [Qemu-devel] [PATCH v6 03/14] block: rename BlkTransactionState and BdrvActionOps Fam Zheng
2015-09-15 6:11 ` [Qemu-devel] [PATCH v6 04/14] backup: Extract dirty bitmap handling as a separate function Fam Zheng
2015-09-18 11:02 ` Max Reitz
2015-09-15 6:11 ` [Qemu-devel] [PATCH v6 05/14] blockjob: Introduce reference count Fam Zheng
2015-09-21 22:19 ` John Snow
2015-09-15 6:11 ` [Qemu-devel] [PATCH v6 06/14] blockjob: Add .commit and .abort block job actions Fam Zheng
2015-09-21 22:29 ` John Snow
2015-09-22 2:15 ` Fam Zheng
2015-09-15 6:11 ` [Qemu-devel] [PATCH v6 07/14] blockjob: Add "completed" and "ret" in BlockJob Fam Zheng
2015-09-15 6:11 ` [Qemu-devel] [PATCH v6 08/14] blockjob: Simplify block_job_finish_sync Fam Zheng
2015-09-21 22:50 ` John Snow
2015-09-15 6:11 ` [Qemu-devel] [PATCH v6 09/14] block: Add block job transactions Fam Zheng
2015-09-18 11:16 ` Max Reitz
2015-09-21 23:23 ` John Snow
2015-09-22 2:32 ` Fam Zheng
2015-09-15 6:11 ` Fam Zheng [this message]
2015-09-18 11:20 ` [Qemu-devel] [PATCH v6 10/14] blockdev: make BlockJobTxn available to qmp 'transaction' Max Reitz
2015-09-15 6:11 ` [Qemu-devel] [PATCH v6 11/14] block/backup: support block job transactions Fam Zheng
2015-09-15 14:43 ` Eric Blake
2015-09-18 11:40 ` Max Reitz
2015-09-15 6:11 ` [Qemu-devel] [PATCH v6 12/14] iotests: 124 - transactional failure test Fam Zheng
2015-09-15 6:11 ` [Qemu-devel] [PATCH v6 13/14] qmp-commands.hx: Update the supported 'transaction' operations Fam Zheng
2015-09-15 6:11 ` [Qemu-devel] [PATCH v6 14/14] tests: add BlockJobTxn unit test Fam Zheng
2015-09-18 11:45 ` Max Reitz
2015-09-22 2:11 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1442297513-7001-11-git-send-email-famz@redhat.com \
--to=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vsementsov@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).