From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38836) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcBy6-0006F9-1b for qemu-devel@nongnu.org; Wed, 16 Sep 2015 08:37:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZcBy1-0008WU-BC for qemu-devel@nongnu.org; Wed, 16 Sep 2015 08:37:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56957) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcBy1-0008WO-6C for qemu-devel@nongnu.org; Wed, 16 Sep 2015 08:37:41 -0400 Message-ID: <1442407057.26770.11.camel@redhat.com> From: Gerd Hoffmann Date: Wed, 16 Sep 2015 14:37:37 +0200 In-Reply-To: <1441806613-13775-20-git-send-email-pbonzini@redhat.com> References: <1441806613-13775-1-git-send-email-pbonzini@redhat.com> <1441806613-13775-20-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL 19/43] rcu: init rcu_registry_lock after fork List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: "Emilio G. Cota" , qemu-devel@nongnu.org On Mi, 2015-09-09 at 15:49 +0200, Paolo Bonzini wrote: > From: "Emilio G. Cota" > > We were unlocking this lock after fork, which is wrong since > only the thread that holds a mutex is allowed to unlock it. This breaks libvirt capability probing. I see qemu running: /home/kraxel/projects/qemu/build-default/x86_64-softmmu/qemu-system-x86_64 -S -no-user-config -nodefaults -nographic -M none -qmp unix:/var/lib/libvirt/qemu/capabilities.monitor.sock,server,nowait -pidfile /var/lib/libvirt/qemu/capabilities.pidfile -daemonize and libvirt is stuck until I kill qemu. cheers, Gerd