From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56653) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcOS9-0007s0-Sv for qemu-devel@nongnu.org; Wed, 16 Sep 2015 21:57:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZcOS6-0004zM-Lk for qemu-devel@nongnu.org; Wed, 16 Sep 2015 21:57:37 -0400 Received: from mail-wi0-f179.google.com ([209.85.212.179]:34439) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcOS6-0004yt-G7 for qemu-devel@nongnu.org; Wed, 16 Sep 2015 21:57:34 -0400 Received: by wicfx3 with SMTP id fx3so4231177wic.1 for ; Wed, 16 Sep 2015 18:57:32 -0700 (PDT) From: shannon.zhao@linaro.org Date: Thu, 17 Sep 2015 09:57:21 +0800 Message-Id: <1442455041-6596-1-git-send-email-shannon.zhao@linaro.org> Subject: [Qemu-devel] [PATCH] hw/arm/virt-acpi-build: Fix wrong size of flash List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, peter.maydell@linaro.org Cc: peter.huangpeng@huawei.com, graeme.gregory@linaro.org, zhaoshenglong@huawei.com From: Shannon Zhao While virt machine creates two flash devices with total size 0x08000000, it wrongly uses this total size for each one. So it will overlap other MMIO spaces. Signed-off-by: Shannon Zhao --- hw/arm/virt-acpi-build.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c index 2073573..bc858c8 100644 --- a/hw/arm/virt-acpi-build.c +++ b/hw/arm/virt-acpi-build.c @@ -114,7 +114,7 @@ static void acpi_dsdt_add_flash(Aml *scope, const MemMapEntry *flash_memmap) { Aml *dev, *crs; hwaddr base = flash_memmap->base; - hwaddr size = flash_memmap->size; + hwaddr size = flash_memmap->size / 2; dev = aml_device("FLS0"); aml_append(dev, aml_name_decl("_HID", aml_string("LNRO0015"))); -- 2.1.0