qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	Peter Crosthwaite <crosthwaitepeter@gmail.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Peter Crosthwaite <crosthwaite.peter@gmail.com>
Subject: [Qemu-devel] [PULL 4/4] net: smc91c111: flush packets on RCR register changes
Date: Thu, 17 Sep 2015 12:44:01 +0100	[thread overview]
Message-ID: <1442490241-17702-5-git-send-email-stefanha@redhat.com> (raw)
In-Reply-To: <1442490241-17702-1-git-send-email-stefanha@redhat.com>

From: Peter Crosthwaite <crosthwaitepeter@gmail.com>

The SOFT_RST or RXEN in the control register can be used as a condition
to unblock the net layer via can_receive(). So check for possible
flushes on RCR changes. This will drop all pending packets on soft
reset or disable which is the functional intent of the can_receive()
logic.

Signed-off-by: Peter Crosthwaite <crosthwaite.peter@gmail.com>
Reviewed-by: Fam Zheng <famz@redhat.com>
Tested-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Message-id: b114d4c96f4afbdaa15f1361d9c07e3021755915.1441873621.git.crosthwaite.peter@gmail.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 hw/net/smc91c111.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/net/smc91c111.c b/hw/net/smc91c111.c
index 8fc3deb..c19cdd1 100644
--- a/hw/net/smc91c111.c
+++ b/hw/net/smc91c111.c
@@ -331,6 +331,7 @@ static void smc91c111_writeb(void *opaque, hwaddr offset,
             if (s->rcr & RCR_SOFT_RST) {
                 smc91c111_reset(DEVICE(s));
             }
+            smc91c111_flush_queued_packets(s);
             return;
         case 10: case 11: /* RPCR */
             /* Ignored */
-- 
2.4.3

  parent reply	other threads:[~2015-09-17 11:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-17 11:43 [Qemu-devel] [PULL 0/4] Net patches Stefan Hajnoczi
2015-09-17 11:43 ` [Qemu-devel] [PULL 1/4] MAINTAINERS: Stefan will not maintain net subsystem Stefan Hajnoczi
2015-09-17 11:43 ` [Qemu-devel] [PULL 2/4] net: smc91c111: guard flush_queued_packets() on can_rx() Stefan Hajnoczi
2015-09-17 11:44 ` [Qemu-devel] [PULL 3/4] net: smc91c111: gate can_receive() on rx FIFO having a slot Stefan Hajnoczi
2015-09-17 11:44 ` Stefan Hajnoczi [this message]
2015-09-17 13:29 ` [Qemu-devel] [PULL 0/4] Net patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1442490241-17702-5-git-send-email-stefanha@redhat.com \
    --to=stefanha@redhat.com \
    --cc=crosthwaite.peter@gmail.com \
    --cc=crosthwaitepeter@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).