From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47400) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcrVb-0008MJ-KQ for qemu-devel@nongnu.org; Fri, 18 Sep 2015 04:59:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZcrVY-000662-AT for qemu-devel@nongnu.org; Fri, 18 Sep 2015 04:59:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38695) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcrVY-00065s-4E for qemu-devel@nongnu.org; Fri, 18 Sep 2015 04:59:04 -0400 From: =?UTF-8?q?Marc=20Mar=C3=AD?= Date: Fri, 18 Sep 2015 10:58:45 +0200 Message-Id: <1442566729-5133-2-git-send-email-markmb@redhat.com> In-Reply-To: <1442566729-5133-1-git-send-email-markmb@redhat.com> References: <1442566703-5091-1-git-send-email-markmb@redhat.com> <1442566729-5133-1-git-send-email-markmb@redhat.com> Subject: [Qemu-devel] [PATCH v3 1/5] fw_cfg: document fw_cfg_modify_iXX() update functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Drew , Stefan Hajnoczi , "Gabriel L. Somlo" , Kevin O'Connor , Gerd Hoffmann , Laszlo From: "Gabriel L. Somlo" Document the behavior of fw_cfg_modify_iXX() for leak-less updating of integer-type blobs. Currently only fw_cfg_modify_i16() is coded, but 32- and 64-bit versions may be added later if necessary.. Signed-off-by: Gabriel Somlo Signed-off-by: Gerd Hoffmann Reviewed-by: Laszlo Ersek --- docs/specs/fw_cfg.txt | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/docs/specs/fw_cfg.txt b/docs/specs/fw_cfg.txt index 74351dd..5bc7b96 100644 --- a/docs/specs/fw_cfg.txt +++ b/docs/specs/fw_cfg.txt @@ -159,6 +159,17 @@ will convert a 16-, 32-, or 64-bit integer to little-endian, then add a dynamically allocated copy of the appropriately sized item to fw_cfg under the given selector key value. +== fw_cfg_modify_iXX() == + +Modify the value of an XX-bit item (where XX may be 16, 32, or 64). +Similarly to the corresponding fw_cfg_add_iXX() function set, convert +a 16-, 32-, or 64-bit integer to little endian, create a dynamically +allocated copy of the required size, and replace the existing item at +the given selector key value with the newly allocated one. The previous +item, assumed to have been allocated during an earlier call to +fw_cfg_add_iXX() or fw_cfg_modify_iXX() (of the same width XX), is freed +before the function returns. + == fw_cfg_add_file() == Given a filename (i.e., fw_cfg item name), starting pointer, and size, -- 2.4.3