qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Marc Marí" <markmb@redhat.com>
To: qemu-devel@nongnu.org
Cc: Drew <drjones@redhat.com>, "Stefan Hajnoczi" <stefanha@gmail.com>,
	"Kevin O'Connor" <kevin@koconnor.net>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Marc Marí" <markmb@redhat.com>, Laszlo <lersek@redhat.com>
Subject: [Qemu-devel] [PATCH v3 4/5] Enable fw_cfg DMA interface for ARM
Date: Fri, 18 Sep 2015 10:58:48 +0200	[thread overview]
Message-ID: <1442566729-5133-5-git-send-email-markmb@redhat.com> (raw)
In-Reply-To: <1442566729-5133-1-git-send-email-markmb@redhat.com>

Enable the fw_cfg DMA interface for the ARM virt machine.

Based on Gerd Hoffman's initial implementation.

Signed-off-by: Marc Marí <markmb@redhat.com>
---
 hw/arm/virt.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index 3568107..47f4ad3 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -113,7 +113,7 @@ static const MemMapEntry a15memmap[] = {
     [VIRT_GIC_V2M] =            { 0x08020000, 0x00001000 },
     [VIRT_UART] =               { 0x09000000, 0x00001000 },
     [VIRT_RTC] =                { 0x09010000, 0x00001000 },
-    [VIRT_FW_CFG] =             { 0x09020000, 0x0000000a },
+    [VIRT_FW_CFG] =             { 0x09020000, 0x00000014 },
     [VIRT_MMIO] =               { 0x0a000000, 0x00000200 },
     /* ...repeating for a total of NUM_VIRTIO_TRANSPORTS, each of that size */
     [VIRT_PLATFORM_BUS] =       { 0x0c000000, 0x02000000 },
@@ -651,13 +651,13 @@ static void create_flash(const VirtBoardInfo *vbi)
     g_free(nodename);
 }
 
-static void create_fw_cfg(const VirtBoardInfo *vbi)
+static void create_fw_cfg(const VirtBoardInfo *vbi, AddressSpace *as)
 {
     hwaddr base = vbi->memmap[VIRT_FW_CFG].base;
     hwaddr size = vbi->memmap[VIRT_FW_CFG].size;
     char *nodename;
 
-    fw_cfg_init_mem_wide(base + 8, base, 8, 0, NULL);
+    fw_cfg_init_mem_wide(base + 8, base, 8, base + 16, as);
 
     nodename = g_strdup_printf("/fw-cfg@%" PRIx64, base);
     qemu_fdt_add_subnode(vbi->fdt, nodename);
@@ -919,6 +919,7 @@ static void machvirt_init(MachineState *machine)
 
     create_fdt(vbi);
 
+
     for (n = 0; n < smp_cpus; n++) {
         ObjectClass *oc = cpu_class_by_name(TYPE_ARM_CPU, cpustr[0]);
         CPUClass *cc = CPU_CLASS(oc);
@@ -984,7 +985,7 @@ static void machvirt_init(MachineState *machine)
      */
     create_virtio_devices(vbi, pic);
 
-    create_fw_cfg(vbi);
+    create_fw_cfg(vbi, &address_space_memory);
     rom_set_fw(fw_cfg_find());
 
     guest_info->smp_cpus = smp_cpus;
-- 
2.4.3

  parent reply	other threads:[~2015-09-18  8:59 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-18  8:58 [Qemu-devel] QEMU fw_cfg DMA interface Marc Marí
2015-09-18  8:58 ` [Qemu-devel] [PATCH v3 0/5] " Marc Marí
2015-09-18  8:58   ` [Qemu-devel] [PATCH v3 1/5] fw_cfg: document fw_cfg_modify_iXX() update functions Marc Marí
2015-09-18  8:58   ` [Qemu-devel] [PATCH v3 2/5] fw_cfg DMA interface documentation Marc Marí
2015-09-18 15:15     ` Peter Maydell
2015-09-18  8:58   ` [Qemu-devel] [PATCH v3 3/5] Implement fw_cfg DMA interface Marc Marí
2015-09-18 15:31     ` Peter Maydell
2015-09-18 18:29     ` Kevin O'Connor
2015-09-18  8:58   ` Marc Marí [this message]
2015-09-18 15:15     ` [Qemu-devel] [PATCH v3 4/5] Enable fw_cfg DMA interface for ARM Peter Maydell
2015-09-18 19:33     ` Laszlo Ersek
2015-09-18 20:16     ` Laszlo Ersek
2015-09-18 20:24       ` Marc Marí
2015-09-18 23:10         ` Laszlo Ersek
2015-09-19 13:09           ` Marc Marí
2015-10-22 21:22           ` Gabriel L. Somlo
2015-10-26 10:48             ` Stefan Hajnoczi
2015-10-26 12:49               ` Gabriel L. Somlo
2015-10-26 13:38                 ` Laszlo Ersek
2015-10-26 14:21                   ` Gabriel L. Somlo
2015-10-27 11:11                   ` Gerd Hoffmann
2015-10-27 12:43                     ` Laszlo Ersek
2015-10-28  1:12                       ` Gabriel L. Somlo
2015-10-28 10:42                         ` Laszlo Ersek
2015-09-18  8:58   ` [Qemu-devel] [PATCH v3 5/5] Enable fw_cfg DMA interface for x86 Marc Marí
2015-09-18 10:58     ` Gerd Hoffmann
2015-09-18 15:12       ` Peter Maydell
2015-09-18 18:25   ` [Qemu-devel] [PATCH v3 0/5] fw_cfg DMA interface Kevin O'Connor
2015-09-18 19:14     ` Marc Marí
2015-09-18 22:47     ` Peter Maydell
2015-09-18 23:43       ` Kevin O'Connor
2015-09-19  9:48         ` Peter Maydell
2015-09-19 15:15           ` Kevin O'Connor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1442566729-5133-5-git-send-email-markmb@redhat.com \
    --to=markmb@redhat.com \
    --cc=drjones@redhat.com \
    --cc=kevin@koconnor.net \
    --cc=kraxel@redhat.com \
    --cc=lersek@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).