From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41297)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1ZctNT-0000CS-JX
	for qemu-devel@nongnu.org; Fri, 18 Sep 2015 06:58:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1ZctNP-0003xr-Fh
	for qemu-devel@nongnu.org; Fri, 18 Sep 2015 06:58:51 -0400
Received: from mx1.redhat.com ([209.132.183.28]:35413)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1ZctNP-0003xd-AU
	for qemu-devel@nongnu.org; Fri, 18 Sep 2015 06:58:47 -0400
Message-ID: <1442573922.29362.7.camel@redhat.com>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Fri, 18 Sep 2015 12:58:42 +0200
In-Reply-To: <1442566729-5133-6-git-send-email-markmb@redhat.com>
References: <1442566703-5091-1-git-send-email-markmb@redhat.com>
	<1442566729-5133-1-git-send-email-markmb@redhat.com>
	<1442566729-5133-6-git-send-email-markmb@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 5/5] Enable fw_cfg DMA interface for x86
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Marc =?ISO-8859-1?Q?Mar=ED?= <markmb@redhat.com>
Cc: Stefan Hajnoczi <stefanha@gmail.com>, Drew <drjones@redhat.com>, Kevin O'Connor <kevin@koconnor.net>, Laszlo <lersek@redhat.com>, qemu-devel@nongnu.org

  Hi,

> -    fw_cfg = fw_cfg_init_io(BIOS_CFG_IOPORT);
> +    fw_cfg = fw_cfg_init_io_dma(BIOS_CFG_IOPORT, BIOS_CFG_IOPORT + 4, as);

> +    as = g_malloc(sizeof(*as));
> +    address_space_init(as, ram_below_4g, "pc.as");
> +    fw_cfg = bochs_bios_init(as);

I think we can use address_space_memory on x86 too (and can remove the
AddressSpace argument to fw_cfg_init_io_dma).

Otherwise the series looks fine to me (and thanks for picking it up).

cheers,
  Gerd