From: Leon Alrae <leon.alrae@imgtec.com>
To: qemu-devel@nongnu.org
Cc: Petar Jovanovic <petar.jovanovic@imgtec.com>
Subject: [Qemu-devel] [PULL 02/10] target-mips: remove wrong checks for recip.fmt and rsqrt.fmt
Date: Fri, 18 Sep 2015 12:25:27 +0100 [thread overview]
Message-ID: <1442575535-4735-3-git-send-email-leon.alrae@imgtec.com> (raw)
In-Reply-To: <1442575535-4735-1-git-send-email-leon.alrae@imgtec.com>
From: Petar Jovanovic <petar.jovanovic@imgtec.com>
Instructions recip.{s|d} and rsqrt.{s|d} do not require 64-bit FPU neither
they require any particular mode for its FPU. This patch removes the checks
that may break a program that uses these instructions.
Signed-off-by: Petar Jovanovic <petar.jovanovic@imgtec.com>
Reviewed-by: Leon Alrae <leon.alrae@imgtec.com>
Signed-off-by: Leon Alrae <leon.alrae@imgtec.com>
---
target-mips/translate.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/target-mips/translate.c b/target-mips/translate.c
index 2f1e724..fadef9e 100644
--- a/target-mips/translate.c
+++ b/target-mips/translate.c
@@ -9290,7 +9290,6 @@ static void gen_farith (DisasContext *ctx, enum fopcode op1,
opn = "movn.s";
break;
case OPC_RECIP_S:
- check_cop1x(ctx);
{
TCGv_i32 fp0 = tcg_temp_new_i32();
@@ -9302,7 +9301,6 @@ static void gen_farith (DisasContext *ctx, enum fopcode op1,
opn = "recip.s";
break;
case OPC_RSQRT_S:
- check_cop1x(ctx);
{
TCGv_i32 fp0 = tcg_temp_new_i32();
@@ -9835,7 +9833,7 @@ static void gen_farith (DisasContext *ctx, enum fopcode op1,
opn = "movn.d";
break;
case OPC_RECIP_D:
- check_cp1_64bitmode(ctx);
+ check_cp1_registers(ctx, fs | fd);
{
TCGv_i64 fp0 = tcg_temp_new_i64();
@@ -9847,7 +9845,7 @@ static void gen_farith (DisasContext *ctx, enum fopcode op1,
opn = "recip.d";
break;
case OPC_RSQRT_D:
- check_cp1_64bitmode(ctx);
+ check_cp1_registers(ctx, fs | fd);
{
TCGv_i64 fp0 = tcg_temp_new_i64();
--
2.1.0
next prev parent reply other threads:[~2015-09-18 11:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-18 11:25 [Qemu-devel] [PULL 00/10] target-mips queue Leon Alrae
2015-09-18 11:25 ` [Qemu-devel] [PULL 01/10] target-mips: Use tcg_gen_extrh_i64_i32 Leon Alrae
2015-09-18 11:25 ` Leon Alrae [this message]
2015-09-18 11:25 ` [Qemu-devel] [PULL 03/10] target-mips: Fix RDHWR on CP0.Count Leon Alrae
2015-09-18 11:25 ` [Qemu-devel] [PULL 04/10] target-mips: get rid of MIPS_DEBUG Leon Alrae
2015-09-18 11:25 ` [Qemu-devel] [PULL 05/10] target-mips: get rid of MIPS_DEBUG_SIGN_EXTENSIONS Leon Alrae
2015-09-18 11:25 ` [Qemu-devel] [PULL 06/10] pic32: use LCG algorithm for generated random index of TLBWR instruction Leon Alrae
2015-09-18 11:25 ` [Qemu-devel] [PULL 07/10] target-mips: fix corner case in TLBWR causing QEMU to hang Leon Alrae
2015-09-18 11:25 ` [Qemu-devel] [PULL 08/10] target-mips: add missing restriction in DAUI instruction Leon Alrae
2015-09-18 11:25 ` [Qemu-devel] [PULL 09/10] target-mips: correct MTC0 instruction on MIPS64 Leon Alrae
2015-09-18 11:25 ` [Qemu-devel] [PULL 10/10] target-mips: improve exception handling Leon Alrae
2015-09-18 13:42 ` [Qemu-devel] [PULL 00/10] target-mips queue Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1442575535-4735-3-git-send-email-leon.alrae@imgtec.com \
--to=leon.alrae@imgtec.com \
--cc=petar.jovanovic@imgtec.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).