qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Leon Alrae <leon.alrae@imgtec.com>
To: qemu-devel@nongnu.org
Cc: Alex Smith <alex.smith@imgtec.com>,
	Aurelien Jarno <aurelien@aurel32.net>
Subject: [Qemu-devel] [PULL 03/10] target-mips: Fix RDHWR on CP0.Count
Date: Fri, 18 Sep 2015 12:25:28 +0100	[thread overview]
Message-ID: <1442575535-4735-4-git-send-email-leon.alrae@imgtec.com> (raw)
In-Reply-To: <1442575535-4735-1-git-send-email-leon.alrae@imgtec.com>

From: Alex Smith <alex.smith@imgtec.com>

For RDHWR on the CP0.Count register, env->CP0_Count was being returned.
This value is a delta against the QEMU_CLOCK_VIRTUAL clock, not the
correct current value of CP0.Count. Use cpu_mips_get_count() instead.

Signed-off-by: Alex Smith <alex.smith@imgtec.com>
Cc: Aurelien Jarno <aurelien@aurel32.net>
Cc: Leon Alrae <leon.alrae@imgtec.com>
Reviewed-by: Leon Alrae <leon.alrae@imgtec.com>
Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>
Signed-off-by: Leon Alrae <leon.alrae@imgtec.com>
---
 target-mips/op_helper.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/target-mips/op_helper.c b/target-mips/op_helper.c
index 1aa9e3c..94de108 100644
--- a/target-mips/op_helper.c
+++ b/target-mips/op_helper.c
@@ -2184,10 +2184,15 @@ target_ulong helper_rdhwr_synci_step(CPUMIPSState *env)
 target_ulong helper_rdhwr_cc(CPUMIPSState *env)
 {
     if ((env->hflags & MIPS_HFLAG_CP0) ||
-        (env->CP0_HWREna & (1 << 2)))
+        (env->CP0_HWREna & (1 << 2))) {
+#ifdef CONFIG_USER_ONLY
         return env->CP0_Count;
-    else
+#else
+        return (int32_t)cpu_mips_get_count(env);
+#endif
+    } else {
         helper_raise_exception(env, EXCP_RI);
+    }
 
     return 0;
 }
-- 
2.1.0

  parent reply	other threads:[~2015-09-18 11:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-18 11:25 [Qemu-devel] [PULL 00/10] target-mips queue Leon Alrae
2015-09-18 11:25 ` [Qemu-devel] [PULL 01/10] target-mips: Use tcg_gen_extrh_i64_i32 Leon Alrae
2015-09-18 11:25 ` [Qemu-devel] [PULL 02/10] target-mips: remove wrong checks for recip.fmt and rsqrt.fmt Leon Alrae
2015-09-18 11:25 ` Leon Alrae [this message]
2015-09-18 11:25 ` [Qemu-devel] [PULL 04/10] target-mips: get rid of MIPS_DEBUG Leon Alrae
2015-09-18 11:25 ` [Qemu-devel] [PULL 05/10] target-mips: get rid of MIPS_DEBUG_SIGN_EXTENSIONS Leon Alrae
2015-09-18 11:25 ` [Qemu-devel] [PULL 06/10] pic32: use LCG algorithm for generated random index of TLBWR instruction Leon Alrae
2015-09-18 11:25 ` [Qemu-devel] [PULL 07/10] target-mips: fix corner case in TLBWR causing QEMU to hang Leon Alrae
2015-09-18 11:25 ` [Qemu-devel] [PULL 08/10] target-mips: add missing restriction in DAUI instruction Leon Alrae
2015-09-18 11:25 ` [Qemu-devel] [PULL 09/10] target-mips: correct MTC0 instruction on MIPS64 Leon Alrae
2015-09-18 11:25 ` [Qemu-devel] [PULL 10/10] target-mips: improve exception handling Leon Alrae
2015-09-18 13:42 ` [Qemu-devel] [PULL 00/10] target-mips queue Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1442575535-4735-4-git-send-email-leon.alrae@imgtec.com \
    --to=leon.alrae@imgtec.com \
    --cc=alex.smith@imgtec.com \
    --cc=aurelien@aurel32.net \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).