From: Leon Alrae <leon.alrae@imgtec.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 08/10] target-mips: add missing restriction in DAUI instruction
Date: Fri, 18 Sep 2015 12:25:33 +0100 [thread overview]
Message-ID: <1442575535-4735-9-git-send-email-leon.alrae@imgtec.com> (raw)
In-Reply-To: <1442575535-4735-1-git-send-email-leon.alrae@imgtec.com>
rs cannot be the zero register, Reserved Instruction exception must be
signalled for this case.
Signed-off-by: Leon Alrae <leon.alrae@imgtec.com>
Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>
---
target-mips/translate.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/target-mips/translate.c b/target-mips/translate.c
index cd0cf8b..0883782 100644
--- a/target-mips/translate.c
+++ b/target-mips/translate.c
@@ -19525,7 +19525,9 @@ static void decode_opc(CPUMIPSState *env, DisasContext *ctx)
#if defined(TARGET_MIPS64)
/* OPC_DAUI */
check_mips_64(ctx);
- if (rt != 0) {
+ if (rs == 0) {
+ generate_exception(ctx, EXCP_RI);
+ } else if (rt != 0) {
TCGv t0 = tcg_temp_new();
gen_load_gpr(t0, rs);
tcg_gen_addi_tl(cpu_gpr[rt], t0, imm << 16);
--
2.1.0
next prev parent reply other threads:[~2015-09-18 11:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-18 11:25 [Qemu-devel] [PULL 00/10] target-mips queue Leon Alrae
2015-09-18 11:25 ` [Qemu-devel] [PULL 01/10] target-mips: Use tcg_gen_extrh_i64_i32 Leon Alrae
2015-09-18 11:25 ` [Qemu-devel] [PULL 02/10] target-mips: remove wrong checks for recip.fmt and rsqrt.fmt Leon Alrae
2015-09-18 11:25 ` [Qemu-devel] [PULL 03/10] target-mips: Fix RDHWR on CP0.Count Leon Alrae
2015-09-18 11:25 ` [Qemu-devel] [PULL 04/10] target-mips: get rid of MIPS_DEBUG Leon Alrae
2015-09-18 11:25 ` [Qemu-devel] [PULL 05/10] target-mips: get rid of MIPS_DEBUG_SIGN_EXTENSIONS Leon Alrae
2015-09-18 11:25 ` [Qemu-devel] [PULL 06/10] pic32: use LCG algorithm for generated random index of TLBWR instruction Leon Alrae
2015-09-18 11:25 ` [Qemu-devel] [PULL 07/10] target-mips: fix corner case in TLBWR causing QEMU to hang Leon Alrae
2015-09-18 11:25 ` Leon Alrae [this message]
2015-09-18 11:25 ` [Qemu-devel] [PULL 09/10] target-mips: correct MTC0 instruction on MIPS64 Leon Alrae
2015-09-18 11:25 ` [Qemu-devel] [PULL 10/10] target-mips: improve exception handling Leon Alrae
2015-09-18 13:42 ` [Qemu-devel] [PULL 00/10] target-mips queue Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1442575535-4735-9-git-send-email-leon.alrae@imgtec.com \
--to=leon.alrae@imgtec.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).