qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 7/8] loader: Fix memory_region_init_resizeable_ram() error handling
Date: Fri, 18 Sep 2015 15:22:53 +0200	[thread overview]
Message-ID: <1442582574-14275-8-git-send-email-armbru@redhat.com> (raw)
In-Reply-To: <1442582574-14275-1-git-send-email-armbru@redhat.com>

Commit ef701d7 screwed up handling of out-of-memory conditions.
Before the commit, we report the error and exit(1), in one place.  The
commit lifts the error handling up the call chain some, to three
places.  Fine.  Except it uses &error_abort in these places, changing
the behavior from exit(1) to abort(), and thus undoing the work of
commit 3922825 "exec: Don't abort when we can't allocate guest
memory".

The previous commit fixed up uses of memory_region_init_ram().  One of
them was replaced by memory_region_init_resizeable_ram() [sic!] in
commit a166614, so Coccinelle missed it.  Fix it up.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <1441983105-26376-4-git-send-email-armbru@redhat.com>
Reviewed-by: Peter Crosthwaite <crosthwaite.peter@gmail.com>
---
 hw/core/loader.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/core/loader.c b/hw/core/loader.c
index a96a74e..eb67f05 100644
--- a/hw/core/loader.c
+++ b/hw/core/loader.c
@@ -740,7 +740,7 @@ static void *rom_set_mr(Rom *rom, Object *owner, const char *name)
     memory_region_init_resizeable_ram(rom->mr, owner, name,
                                       rom->datasize, rom->romsize,
                                       fw_cfg_resized,
-                                      &error_abort);
+                                      &error_fatal);
     memory_region_set_readonly(rom->mr, true);
     vmstate_register_ram_global(rom->mr);
 
-- 
2.4.3

  parent reply	other threads:[~2015-09-18 13:23 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-18 13:22 [Qemu-devel] [PULL 0/8] Error reporting patches Markus Armbruster
2015-09-18 13:22 ` [Qemu-devel] [PULL 1/8] error: only prepend timestamp on stderr Markus Armbruster
2015-09-18 13:22 ` [Qemu-devel] [PULL 2/8] hmp: Allow for error message hints on HMP Markus Armbruster
2015-09-22 15:23   ` Kevin Wolf
2015-09-22 17:02     ` Eric Blake
2015-09-22 23:02       ` [Qemu-devel] [Qemu-block] " John Snow
2015-09-18 13:22 ` [Qemu-devel] [PULL 3/8] error: Copy location information in error_copy() Markus Armbruster
2015-09-18 13:22 ` [Qemu-devel] [PULL 4/8] MAINTAINERS: Add "Error reporting" entry Markus Armbruster
2015-09-18 13:22 ` [Qemu-devel] [PULL 5/8] error: New error_fatal Markus Armbruster
2015-09-18 13:22 ` [Qemu-devel] [PULL 6/8] Fix bad error handling after memory_region_init_ram() Markus Armbruster
2015-09-18 13:22 ` Markus Armbruster [this message]
2015-09-18 13:22 ` [Qemu-devel] [PULL 8/8] memory: Fix bad error handling in memory_region_init_ram_ptr() Markus Armbruster
2015-09-18 15:57 ` [Qemu-devel] [PULL 0/8] Error reporting patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1442582574-14275-8-git-send-email-armbru@redhat.com \
    --to=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).