From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38655) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZcxWe-0007mm-Uo for qemu-devel@nongnu.org; Fri, 18 Sep 2015 11:24:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZcxWe-0006BP-7X for qemu-devel@nongnu.org; Fri, 18 Sep 2015 11:24:36 -0400 From: Max Reitz Date: Fri, 18 Sep 2015 17:23:01 +0200 Message-Id: <1442589793-7105-27-git-send-email-mreitz@redhat.com> In-Reply-To: <1442589793-7105-1-git-send-email-mreitz@redhat.com> References: <1442589793-7105-1-git-send-email-mreitz@redhat.com> Subject: [Qemu-devel] [PATCH v5 26/38] block: Add blk_remove_bs() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-block@nongnu.org Cc: Kevin Wolf , Alberto Garcia , Markus Armbruster , qemu-devel@nongnu.org, Max Reitz , John Snow , Stefan Hajnoczi This function removes the BlockDriverState associated with the given BlockBackend from that BB and sets the BDS pointer in the BB to NULL. Signed-off-by: Max Reitz Reviewed-by: Eric Blake --- block/block-backend.c | 22 +++++++++++++++++++++- include/sysemu/block-backend.h | 1 + 2 files changed, 22 insertions(+), 1 deletion(-) diff --git a/block/block-backend.c b/block/block-backend.c index 652385e..66ecc07 100644 --- a/block/block-backend.c +++ b/block/block-backend.c @@ -314,6 +314,22 @@ void blk_hide_on_behalf_of_hmp_drive_del(BlockBackend *blk) } /* + * Disassociates the currently associated BlockDriverState from @blk. + */ +void blk_remove_bs(BlockBackend *blk) +{ + if (!blk->bs) { + return; + } + + blk_update_root_state(blk); + + bdrv_unref(blk->bs); + blk->bs->blk = NULL; + blk->bs = NULL; +} + +/* * Associates a new BlockDriverState with @blk. */ void blk_insert_bs(BlockBackend *blk, BlockDriverState *bs) @@ -323,9 +339,13 @@ void blk_insert_bs(BlockBackend *blk, BlockDriverState *bs) } assert(!blk->bs); - assert(!bs->blk); bdrv_ref(bs); blk->bs = bs; + + if (bs->blk) { + blk_remove_bs(bs->blk); + } + bs->blk = blk; } diff --git a/include/sysemu/block-backend.h b/include/sysemu/block-backend.h index 9306a52..14a6d32 100644 --- a/include/sysemu/block-backend.h +++ b/include/sysemu/block-backend.h @@ -72,6 +72,7 @@ BlockBackend *blk_by_name(const char *name); BlockBackend *blk_next(BlockBackend *blk); BlockDriverState *blk_bs(BlockBackend *blk); +void blk_remove_bs(BlockBackend *blk); void blk_insert_bs(BlockBackend *blk, BlockDriverState *bs); void blk_hide_on_behalf_of_hmp_drive_del(BlockBackend *blk); -- 2.5.2