qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Max Reitz <mreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Alberto Garcia <berto@igalia.com>,
	Markus Armbruster <armbru@redhat.com>,
	qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
	John Snow <jsnow@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PATCH v5 29/38] blockdev: Add blockdev-remove-medium
Date: Fri, 18 Sep 2015 17:23:04 +0200	[thread overview]
Message-ID: <1442589793-7105-30-git-send-email-mreitz@redhat.com> (raw)
In-Reply-To: <1442589793-7105-1-git-send-email-mreitz@redhat.com>

Signed-off-by: Max Reitz <mreitz@redhat.com>
---
 blockdev.c           | 30 ++++++++++++++++++++++++++++++
 qapi/block-core.json | 15 +++++++++++++++
 qmp-commands.hx      | 45 +++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 90 insertions(+)

diff --git a/blockdev.c b/blockdev.c
index d07bf8a..b7835e4 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -2131,6 +2131,36 @@ void qmp_blockdev_close_tray(const char *device, Error **errp)
     blk_dev_change_media_cb(blk, true);
 }
 
+void qmp_blockdev_remove_medium(const char *device, Error **errp)
+{
+    BlockBackend *blk;
+    bool has_device;
+
+    blk = blk_by_name(device);
+    if (!blk) {
+        error_set(errp, ERROR_CLASS_DEVICE_NOT_FOUND,
+                  "Device '%s' not found", device);
+        return;
+    }
+
+    /* For BBs without a device, we can exchange the BDS tree at will */
+    has_device = blk_get_attached_dev(blk);
+
+    if (has_device && !blk_dev_has_removable_media(blk)) {
+        error_setg(errp, "Device '%s' is not removable", device);
+        return;
+    }
+
+    if (has_device && !blk_dev_is_tray_open(blk)) {
+        error_setg(errp, "Tray of device '%s' is not open", device);
+        return;
+    }
+
+    if (blk_bs(blk)) {
+        blk_remove_bs(blk);
+    }
+}
+
 /* throttling disk I/O limits */
 void qmp_block_set_io_throttle(const char *device, int64_t bps, int64_t bps_rd,
                                int64_t bps_wr,
diff --git a/qapi/block-core.json b/qapi/block-core.json
index 1a51829..8edf5d9 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -1915,6 +1915,21 @@
 { 'command': 'blockdev-close-tray',
   'data': { 'device': 'str' } }
 
+##
+# @blockdev-remove-medium:
+#
+# Removes a medium (a block driver state tree) from a block device. That block
+# device's tray must currently be open.
+#
+# If the tray is open and there is no medium inserted, this will be a no-op.
+#
+# @device: block device name
+#
+# Since: 2.5
+##
+{ 'command': 'blockdev-remove-medium',
+  'data': { 'device': 'str' } }
+
 
 ##
 # @BlockErrorAction
diff --git a/qmp-commands.hx b/qmp-commands.hx
index 7c7125a..a9594a7 100644
--- a/qmp-commands.hx
+++ b/qmp-commands.hx
@@ -3971,6 +3971,51 @@ Example:
 EQMP
 
     {
+        .name       = "blockdev-remove-medium",
+        .args_type  = "device:s",
+        .mhandler.cmd_new = qmp_marshal_input_blockdev_remove_medium,
+    },
+
+SQMP
+blockdev-remove-medium
+----------------------
+
+Removes a medium (a block driver state tree) from a block device. That block
+device's tray must currently be open.
+
+If the tray is open and there is no medium inserted, this will be a no-op.
+
+Arguments:
+
+- "device": block device name (json-string)
+
+Example:
+
+-> { "execute": "blockdev-remove-medium",
+     "arguments": { "device": "ide1-cd0" } }
+
+<- { "error": { "class": "GenericError",
+                "desc": "Tray of device 'ide1-cd0' is not open" } }
+
+-> { "execute": "blockdev-open-tray",
+     "arguments": { "device": "ide1-cd0" } }
+
+<- { "timestamp": { "seconds": 1418751627,
+                    "microseconds": 549958 },
+     "event": "DEVICE_TRAY_MOVED",
+     "data": { "device": "ide1-cd0",
+               "tray-open": true } }
+
+<- { "return": {} }
+
+-> { "execute": "blockdev-remove-medium",
+     "arguments": { "device": "ide1-cd0" } }
+
+<- { "return": {} }
+
+EQMP
+
+    {
         .name       = "query-named-block-nodes",
         .args_type  = "",
         .mhandler.cmd_new = qmp_marshal_input_query_named_block_nodes,
-- 
2.5.2

  parent reply	other threads:[~2015-09-18 15:24 UTC|newest]

Thread overview: 74+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-18 15:22 [Qemu-devel] [PATCH v5 00/38] blockdev: BlockBackend and media Max Reitz
2015-09-18 15:22 ` [Qemu-devel] [PATCH v5 01/38] block: Remove host floppy support Max Reitz
2015-09-18 15:31   ` Eric Blake
2015-09-18 15:22 ` [Qemu-devel] [PATCH v5 02/38] block: Set BDRV_O_INCOMING in bdrv_fill_options() Max Reitz
2015-09-18 15:32   ` Eric Blake
2015-09-29  8:53   ` Alberto Garcia
2015-09-18 15:22 ` [Qemu-devel] [PATCH v5 03/38] blockdev: Allow creation of BDS trees without BB Max Reitz
2015-09-18 15:34   ` Eric Blake
2015-09-29  8:45   ` Alberto Garcia
2015-09-18 15:22 ` [Qemu-devel] [PATCH v5 04/38] iotests: Only create BB if necessary Max Reitz
2015-09-18 16:00   ` Eric Blake
2015-09-18 15:22 ` [Qemu-devel] [PATCH v5 05/38] block: Make bdrv_is_inserted() return a bool Max Reitz
2015-09-18 15:22 ` [Qemu-devel] [PATCH v5 06/38] block: Add blk_is_available() Max Reitz
2015-09-18 15:22 ` [Qemu-devel] [PATCH v5 07/38] block: Make bdrv_is_inserted() recursive Max Reitz
2015-09-18 16:20   ` Eric Blake
2015-09-29  9:15   ` Alberto Garcia
2015-09-30 14:32     ` Max Reitz
2015-09-18 15:22 ` [Qemu-devel] [PATCH v5 08/38] block/raw_bsd: Drop raw_is_inserted() Max Reitz
2015-09-18 16:20   ` Eric Blake
2015-09-29 10:47   ` Alberto Garcia
2015-09-18 15:22 ` [Qemu-devel] [PATCH v5 09/38] block: Invoke change media CB before NULLing drv Max Reitz
2015-09-18 16:22   ` Eric Blake
2015-09-18 15:22 ` [Qemu-devel] [PATCH v5 10/38] hw/block/fdc: Implement tray status Max Reitz
2015-09-18 16:24   ` Eric Blake
2015-09-18 15:22 ` [Qemu-devel] [PATCH v5 11/38] hw/usb-storage: Check whether BB is inserted Max Reitz
2015-09-18 15:22 ` [Qemu-devel] [PATCH v5 12/38] block: Fix BB AIOCB AioContext without BDS Max Reitz
2015-09-18 15:22 ` [Qemu-devel] [PATCH v5 13/38] block: Move guest_block_size into BlockBackend Max Reitz
2015-09-18 15:22 ` [Qemu-devel] [PATCH v5 14/38] block: Remove wr_highest_sector from BlockAcctStats Max Reitz
2015-09-18 16:59   ` Eric Blake
2015-09-21  7:57     ` Kevin Wolf
2015-09-21 15:53       ` Eric Blake
2015-09-18 15:22 ` [Qemu-devel] [PATCH v5 15/38] block: Move BlockAcctStats into BlockBackend Max Reitz
2015-09-18 15:22 ` [Qemu-devel] [PATCH v5 16/38] block: Move I/O status and error actions into BB Max Reitz
2015-09-18 15:22 ` [Qemu-devel] [PATCH v5 17/38] block: Add BlockBackendRootState Max Reitz
2015-09-22 14:17   ` Kevin Wolf
2015-09-22 15:00     ` Max Reitz
2015-09-29 11:17       ` Alberto Garcia
2015-09-29 12:30         ` Eric Blake
2015-09-29 13:12           ` Kevin Wolf
2015-09-18 15:22 ` [Qemu-devel] [PATCH v5 18/38] block: Make some BB functions fall back to BBRS Max Reitz
2015-09-18 15:22 ` [Qemu-devel] [PATCH v5 19/38] block: Fail requests to empty BlockBackend Max Reitz
2015-09-22 14:30   ` Kevin Wolf
2015-09-22 15:05     ` Max Reitz
2015-09-22 15:13       ` Kevin Wolf
2015-09-18 15:22 ` [Qemu-devel] [PATCH v5 20/38] block: Prepare remaining BB functions for NULL BDS Max Reitz
2015-09-22 14:35   ` Kevin Wolf
2015-09-22 15:07     ` Max Reitz
2015-09-18 15:22 ` [Qemu-devel] [PATCH v5 21/38] block: Add blk_insert_bs() Max Reitz
2015-09-22 14:42   ` Kevin Wolf
2015-09-22 15:20     ` Max Reitz
2015-09-18 15:22 ` [Qemu-devel] [PATCH v5 22/38] block: Prepare for NULL BDS Max Reitz
2015-09-18 19:42   ` Eric Blake
2015-10-07 10:43   ` Kevin Wolf
2015-10-07 15:08     ` Max Reitz
2015-09-18 15:22 ` [Qemu-devel] [PATCH v5 23/38] blockdev: Do not create BDS for empty drive Max Reitz
2015-09-18 15:22 ` [Qemu-devel] [PATCH v5 24/38] blockdev: Pull out blockdev option extraction Max Reitz
2015-09-30 11:16   ` Alberto Garcia
2015-09-18 15:23 ` [Qemu-devel] [PATCH v5 25/38] blockdev: Allow more options for BB-less BDS tree Max Reitz
2015-09-18 15:23 ` [Qemu-devel] [PATCH v5 26/38] block: Add blk_remove_bs() Max Reitz
2015-09-18 15:23 ` [Qemu-devel] [PATCH v5 27/38] blockdev: Add blockdev-open-tray Max Reitz
2015-09-18 15:23 ` [Qemu-devel] [PATCH v5 28/38] blockdev: Add blockdev-close-tray Max Reitz
2015-09-18 15:23 ` Max Reitz [this message]
2015-09-18 15:23 ` [Qemu-devel] [PATCH v5 30/38] blockdev: Add blockdev-insert-medium Max Reitz
2015-09-18 15:23 ` [Qemu-devel] [PATCH v5 31/38] blockdev: Implement eject with basic operations Max Reitz
2015-09-18 15:23 ` [Qemu-devel] [PATCH v5 32/38] blockdev: Implement change " Max Reitz
2015-09-18 15:23 ` [Qemu-devel] [PATCH v5 33/38] block: Inquire tray state before tray-moved events Max Reitz
2015-09-18 15:23 ` [Qemu-devel] [PATCH v5 34/38] qmp: Introduce blockdev-change-medium Max Reitz
2015-09-18 15:23 ` [Qemu-devel] [PATCH v5 35/38] hmp: Use blockdev-change-medium for change command Max Reitz
2015-09-18 15:23 ` [Qemu-devel] [PATCH v5 36/38] blockdev: read-only-mode for blockdev-change-medium Max Reitz
2015-09-18 15:23 ` [Qemu-devel] [PATCH v5 37/38] hmp: Add read-only-mode option to change command Max Reitz
2015-09-18 15:23 ` [Qemu-devel] [PATCH v5 38/38] iotests: Add test for change-related QMP commands Max Reitz
2015-09-22 14:45 ` [Qemu-devel] [PATCH v5 00/38] blockdev: BlockBackend and media Kevin Wolf
2015-09-22 15:09   ` Max Reitz
2015-09-23  6:20     ` Wen Congyang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1442589793-7105-30-git-send-email-mreitz@redhat.com \
    --to=mreitz@redhat.com \
    --cc=armbru@redhat.com \
    --cc=berto@igalia.com \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).