From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57761) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZdynB-000191-26 for qemu-devel@nongnu.org; Mon, 21 Sep 2015 06:57:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zdyn9-0006s2-3B for qemu-devel@nongnu.org; Mon, 21 Sep 2015 06:57:52 -0400 Received: from mailhub.sw.ru ([195.214.232.25]:24051 helo=relay.sw.ru) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zdyn8-0006pg-Ll for qemu-devel@nongnu.org; Mon, 21 Sep 2015 06:57:51 -0400 From: "Denis V. Lunev" Date: Mon, 21 Sep 2015 13:57:29 +0300 Message-Id: <1442833057-8186-2-git-send-email-den@openvz.org> In-Reply-To: <1442833057-8186-1-git-send-email-den@openvz.org> References: <1442833057-8186-1-git-send-email-den@openvz.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH 1/9] apic_internal.h: make some apic_get_* functions externally visible List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Denis V. Lunev" , Paolo Bonzini , qemu-devel@nongnu.org, =?UTF-8?q?Andreas=20F=C3=A4rber?= , Pavel Butsykin From: Pavel Butsykin Move apic_get_bit(), apic_set_bit() to apic_internal.h, make the apic_get_ppr symbol external. It's necessary to work with isr, tmr, irr and ppr outside hw/intc/apic.c Signed-off-by: Pavel Butsykin Signed-off-by: Denis V. Lunev CC: Paolo Bonzini CC: Andreas F=C3=A4rber --- hw/intc/apic.c | 18 +----------------- include/hw/i386/apic_internal.h | 18 ++++++++++++++++++ 2 files changed, 19 insertions(+), 17 deletions(-) diff --git a/hw/intc/apic.c b/hw/intc/apic.c index 77b639c..52ac8b2 100644 --- a/hw/intc/apic.c +++ b/hw/intc/apic.c @@ -51,14 +51,6 @@ static int apic_ffs_bit(uint32_t value) return ctz32(value); } =20 -static inline void apic_set_bit(uint32_t *tab, int index) -{ - int i, mask; - i =3D index >> 5; - mask =3D 1 << (index & 0x1f); - tab[i] |=3D mask; -} - static inline void apic_reset_bit(uint32_t *tab, int index) { int i, mask; @@ -67,14 +59,6 @@ static inline void apic_reset_bit(uint32_t *tab, int i= ndex) tab[i] &=3D ~mask; } =20 -static inline int apic_get_bit(uint32_t *tab, int index) -{ - int i, mask; - i =3D index >> 5; - mask =3D 1 << (index & 0x1f); - return !!(tab[i] & mask); -} - /* return -1 if no bit is set */ static int get_highest_priority_int(uint32_t *tab) { @@ -318,7 +302,7 @@ static uint8_t apic_get_tpr(APICCommonState *s) return s->tpr >> 4; } =20 -static int apic_get_ppr(APICCommonState *s) +int apic_get_ppr(APICCommonState *s) { int tpr, isrv, ppr; =20 diff --git a/include/hw/i386/apic_internal.h b/include/hw/i386/apic_inter= nal.h index 26632ac..5a213bc 100644 --- a/include/hw/i386/apic_internal.h +++ b/include/hw/i386/apic_internal.h @@ -147,4 +147,22 @@ void apic_enable_vapic(DeviceState *d, hwaddr paddr)= ; void vapic_report_tpr_access(DeviceState *dev, CPUState *cpu, target_ulo= ng ip, TPRAccess access); =20 +int apic_get_ppr(APICCommonState *s); + +static inline void apic_set_bit(uint32_t *tab, int index) +{ + int i, mask; + i =3D index >> 5; + mask =3D 1 << (index & 0x1f); + tab[i] |=3D mask; +} + +static inline int apic_get_bit(uint32_t *tab, int index) +{ + int i, mask; + i =3D index >> 5; + mask =3D 1 << (index & 0x1f); + return !!(tab[i] & mask); +} + #endif /* !QEMU_APIC_INTERNAL_H */ --=20 2.1.4