From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60791) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ze96e-0008Dv-SM for qemu-devel@nongnu.org; Mon, 21 Sep 2015 17:58:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ze96d-00019v-IO for qemu-devel@nongnu.org; Mon, 21 Sep 2015 17:58:40 -0400 From: Eric Blake Date: Mon, 21 Sep 2015 15:57:52 -0600 Message-Id: <1442872682-6523-37-git-send-email-eblake@redhat.com> In-Reply-To: <1442872682-6523-1-git-send-email-eblake@redhat.com> References: <1442872682-6523-1-git-send-email-eblake@redhat.com> Subject: [Qemu-devel] [PATCH v5 36/46] qapi: Avoid use of 'data' member of qapi unions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , ehabkost@redhat.com, "open list:Block layer core" , armbru@redhat.com, Gerd Hoffmann , DirtY.iCE.hu@gmail.com, marcandre.lureau@redhat.com qapi code generators currently create a 'void *data' member as part of the anonymous union embedded in the C struct corresponding to a qapi union. However, directly assigning to this member of the union feels a bit fishy, when we can directly use the rest of the struct instead. Signed-off-by: Eric Blake --- blockdev.c | 22 ++++++++++++---------- ui/input.c | 2 +- 2 files changed, 13 insertions(+), 11 deletions(-) diff --git a/blockdev.c b/blockdev.c index bf8a7a2..28a3375 100644 --- a/blockdev.c +++ b/blockdev.c @@ -1052,14 +1052,11 @@ void hmp_commit(Monitor *mon, const QDict *qdict) } } -static void blockdev_do_action(int type, void *data, Error **errp) +static void blockdev_do_action(TransactionAction *action, Error **errp) { - TransactionAction action; TransactionActionList list; - action.type = type; - action.data = data; - list.value = &action; + list.value = action; list.next = NULL; qmp_transaction(&list, errp); } @@ -1085,8 +1082,11 @@ void qmp_blockdev_snapshot_sync(bool has_device, const char *device, .has_mode = has_mode, .mode = mode, }; - blockdev_do_action(TRANSACTION_ACTION_KIND_BLOCKDEV_SNAPSHOT_SYNC, - &snapshot, errp); + TransactionAction action = { + .type = TRANSACTION_ACTION_KIND_BLOCKDEV_SNAPSHOT_SYNC, + .blockdev_snapshot_sync = &snapshot, + }; + blockdev_do_action(&action, errp); } void qmp_blockdev_snapshot_internal_sync(const char *device, @@ -1097,9 +1097,11 @@ void qmp_blockdev_snapshot_internal_sync(const char *device, .device = (char *) device, .name = (char *) name }; - - blockdev_do_action(TRANSACTION_ACTION_KIND_BLOCKDEV_SNAPSHOT_INTERNAL_SYNC, - &snapshot, errp); + TransactionAction action = { + .type = TRANSACTION_ACTION_KIND_BLOCKDEV_SNAPSHOT_INTERNAL_SYNC, + .blockdev_snapshot_internal_sync = &snapshot, + }; + blockdev_do_action(&action, errp); } SnapshotInfo *qmp_blockdev_snapshot_delete_internal_sync(const char *device, diff --git a/ui/input.c b/ui/input.c index fd86571..edd237d 100644 --- a/ui/input.c +++ b/ui/input.c @@ -452,7 +452,7 @@ InputEvent *qemu_input_event_new_move(InputEventKind kind, InputMoveEvent *move = g_new0(InputMoveEvent, 1); evt->type = kind; - evt->data = move; + evt->rel = move; /* also would work as evt->abs */ move->axis = axis; move->value = value; return evt; -- 2.4.3