From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48202) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZeERA-0002UM-RL for qemu-devel@nongnu.org; Mon, 21 Sep 2015 23:40:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZeER1-000255-Py for qemu-devel@nongnu.org; Mon, 21 Sep 2015 23:40:12 -0400 Received: from e28smtp07.in.ibm.com ([122.248.162.7]:51434) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZeER1-0001xV-2M for qemu-devel@nongnu.org; Mon, 21 Sep 2015 23:40:03 -0400 Received: from /spool/local by e28smtp07.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 22 Sep 2015 09:09:57 +0530 From: Bharata B Rao Date: Tue, 22 Sep 2015 09:09:49 +0530 Message-Id: <1442893189-5680-3-git-send-email-bharata@linux.vnet.ibm.com> In-Reply-To: <1442893189-5680-1-git-send-email-bharata@linux.vnet.ibm.com> References: <1442893189-5680-1-git-send-email-bharata@linux.vnet.ibm.com> Subject: [Qemu-devel] [RFC PATCH v0 2/2] spapr: Abort when HTAB of requested size isn't allocated List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: nfont@linux.vnet.ibm.com, Bharata B Rao , qemu-ppc@nongnu.org, mdroth@linux.vnet.ibm.com, david@gibson.dropbear.id.au Terminate the guest when HTAB of requested size isn't allocated by the host. When memory hotplug is attempted on a guest that has booted with less than requested HTAB size, the guest kernel will not be able to gracefully fail the hotplug request. This patch will ensure that we never end up in a situation where memory hotplug fails due to less than requested HTAB size. Signed-off-by: Bharata B Rao --- hw/ppc/spapr.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 4692122..66446af 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -992,6 +992,10 @@ static void spapr_alloc_htab(sPAPRMachineState *spapr) if (shift > 0) { /* Kernel handles htab, we don't need to allocate one */ + if (shift != spapr->htab_shift) { + error_setg(&error_abort, "Failed to allocated requested HTAB size"); + } + spapr->htab_shift = shift; kvmppc_kern_htab = true; -- 2.1.0